Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools, test: update test-npm-package paths #13441

Merged
merged 1 commit into from
Jun 7, 2017
Merged

tools, test: update test-npm-package paths #13441

merged 1 commit into from
Jun 7, 2017

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Jun 3, 2017 •
edited
Loading

Makes the same changes as 9946173 to update the test runner for npm5.

Refs: #12936

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, test

@gibfahn gibfahn added npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jun 3, 2017
@gibfahn gibfahn requested a review from jkrems June 3, 2017 19:45
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jun 3, 2017
jkrems
jkrems approved these changes Jun 3, 2017
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gibfahn gibfahn self-assigned this Jun 6, 2017
@gibfahn
Copy link
Member Author

gibfahn commented Jun 6, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-commit/10411/
CI 2: https://ci.nodejs.org/job/node-test-commit/10415/

Will land tomorrow if no objections

@gibfahn
tools, test: update test-npm-package paths
6bcea5c 
Makes the same changes as
nodejs@9946173
to update the test runner for npm5.

PR-URL: nodejs#13441
Refs: nodejs#12936
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gibfahn gibfahn merged commit 6bcea5c into nodejs:master Jun 7, 2017
@gibfahn gibfahn deleted the npm-cli-bin branch June 7, 2017 15:36
jasnell pushed a commit that referenced this pull request Jun 7, 2017
@gibfahn @jasnell
tools, test: update test-npm-package paths
61eb085 
Makes the same changes as
9946173
to update the test runner for npm5.

PR-URL: #13441
Refs: #12936
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jkrems jkrems jkrems approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees

@gibfahn gibfahn

Labels
npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gibfahn @refack @jasnell @jkrems @thefourtheye @lpinca @nodejs-github-bot