Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x] deps: update V8 to 5.9 #13515

Closed
wants to merge 24 commits into from
Closed

Commits on Jul 21, 2017

  1. deps: update V8 to 5.9.211.35

    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    1fb7a1a View commit details
    Browse the repository at this point in the history
  2. deps: limit regress/regress-crbug-514081 v8 test

    regress/regress-crbug-514081 allocates a 2G block of memory
    and if there  are multiple variants running at the
    same time this can lead to crashes, OOM kills or
    the OS failing to allocate memory.  This patch
    limits us to running a single variant of the test
    
    Fixes: nodejs#6340
    PR-URL: nodejs#6678
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    mhdawson authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    63633a4 View commit details
    Browse the repository at this point in the history
  3. deps: run memory hungry V8 test in exclusive mode

    es6/typedarray-construct-offset-not-smi allocates a 2G block of memory
    and if there  are multiple variants running at the same time this can
    lead to crashes, OOM kills or the OS failing to allocate memory.
    This patch limits us to running a single variant of the test.
    
    Refs: nodejs#6678
    
    PR-URL: nodejs#13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    dcd5c9b View commit details
    Browse the repository at this point in the history
  4. deps: add missing include to V8 i18n.cc

    This is required for ICU 59.1.
    
    PR-URL: nodejs#13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    f835856 View commit details
    Browse the repository at this point in the history
  5. deps: fix addons compilation with VS2013

    VS2013 does not support defaulting move constructor and assignment
    operator. This adds explicit definitions of those methods for two
    classes.
    This fix is required because we still support building addons with
    VS2013 and the incompatibility is in v8.h.
    
    Fixes: nodejs/node-v8#4
    
    PR-URL: nodejs#13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    bzoz authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    88c2af8 View commit details
    Browse the repository at this point in the history
  6. v8: fix stack overflow in recursive method

    HGlobalValueNumberingPhase::CollectSideEffectsOnPathsToDominatedBlock()
    used to self-recurse before this commit, causing stack overflows on
    systems with small stack sizes.  Make it non-recursive by storing
    intermediate results in a heap-allocated list.
    
    Fixes: nodejs#11991
    PR-URL: nodejs#12460
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yang Guo <yangguo@chromium.org>
    bnoordhuis authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    cbabf2a View commit details
    Browse the repository at this point in the history
  7. v8: fix gcc 7 build errors

    Porting nodejs#12392 to V8 5.9
    
    Ref: nodejs#12392
    Fixes: nodejs#10388
    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    b47e758 View commit details
    Browse the repository at this point in the history
  8. deps: cherry-pick bfae9db from upstream v8

    Original commit message:
    
        Update postmortem metadata generator.
    
        Add PropertyDetails::AttributesField +
        PropertyDetails::LocationField.
    
        Review-Url: https://codereview.chromium.org/2842843004
        Cr-Commit-Position: refs/heads/master@{nodejs#44889}
    
    PR-URL: nodejs#12722
    Refs: nodejs/llnode#81
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    bnoordhuis authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    60afd95 View commit details
    Browse the repository at this point in the history
  9. deps: cherry-pick f5fad6d from upstream v8

    Original commit message:
    
        This commit adds a getter for the private is_verbose_ member.
        The use case for this comes from Node.js where the ability to avoid
        calling FatalException if the TryCatch is verbose would be nice
        to have.
    
        BUG=
    
        Review-Url: https://codereview.chromium.org/2840803002
        Cr-Commit-Position: refs/heads/master@{nodejs#45018}
    
    PR-URL: nodejs#12826
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    danbev authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    ad7d46b View commit details
    Browse the repository at this point in the history
  10. deps: cherry-pick 6d38f89 from upstream V8

    Original commit message:
    
        [turbofan] Boost performance of Array.prototype.shift by 4x.
    
        For small arrays, it's way faster to just move the elements instead of
        doing the fairly complex and heavy-weight left-trimming. Crankshaft has
        had this optimization for small arrays already; this CL more or less
        ports this functionality to TurboFan, which yields a 4x speed-up when
        using shift on small arrays (with up to 16 elements).
    
        This should recover some of the regressions reported in the Node.js issues
    
          nodejs#12657
    
        and discovered for the syncthrough module using
    
          https://github.com/mcollina/syncthrough/blob/master/benchmarks/basic.js
    
        as benchmark.
    
        R=jarin@chromium.org
        BUG=v8:6376
    
        Review-Url: https://codereview.chromium.org/2874453002
        Cr-Commit-Position: refs/heads/master@{nodejs#45216}
    
    PR-URL: nodejs#13263
    Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    767320c View commit details
    Browse the repository at this point in the history
  11. deps: backport 4fdf9fd4813 from upstream v8

    Original commit message:
    
        Add documentation for FunctionCallbackInfo
    
        R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org
        BUG=
    
        Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7
        Reviewed-on: https://chromium-review.googlesource.com/484422
        Reviewed-by: Kentaro Hara <haraken@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Commit-Queue: Jochen Eisinger <jochen@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#44927}
    
    Ref: v8/v8@4fdf9fd4813
    
    PR-URL: nodejs#12875
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jeisinger authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    b769749 View commit details
    Browse the repository at this point in the history
  12. v8: do not test v8 with -Werror

    PR-URL: nodejs#12875
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    81895a5 View commit details
    Browse the repository at this point in the history
  13. v8: backport bd59e7452be from upstream v8

    Original commit message:
        [PATCH] Merged: Make Object::GetOwnPropertyDescriptor() take a Name, not a String.
    
        Revision: b5e610c19208ef854755eec67011ca7aff008bf4
    
        NOTRY=true
        NOPRESUBMIT=true
        NOTREECHECKS=true
        TBR=vogelheim@chromium.org
    
        Bug:
        Change-Id: I396b559b28aab6afa138db747711e50cd0da3da7
        Reviewed-on: https://chromium-review.googlesource.com/513927
        Reviewed-by: Michael Achenbach <machenbach@chromium.org>
        Cr-Commit-Position: refs/branch-heads/6.0@{#5}
        Cr-Branched-From: 97dbf624a5eeffb3a8df36d24cdb2a883137385f-refs/heads/6.0.286@{#1}
        Cr-Branched-From: 12e6f1cb5cd9616da7b9d4a7655c088778a6d415-refs/heads/master@{nodejs#45439}
    
    PR-URL: nodejs#13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mi-ac authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    6cd148c View commit details
    Browse the repository at this point in the history
  14. v8: backport a9e56f4f36d from upstream v8

    Because 5.8 still had other uses of the removed flag, there are some extra
    changes in Heap::ConfigureHeap and api.cc:SetResourceConstraints.
    
    Original commit message:
        [heap] Remove max_executable_size resource constraint.
    
        BUG=chromium:716032
    
        Review-Url: https://codereview.chromium.org/2890603007
        Cr-Commit-Position: refs/heads/master@{nodejs#45400}
    
    PR-URL: nodejs#13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    psmarshall authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    876031b View commit details
    Browse the repository at this point in the history
  15. v8: backport 4f82f1d948c from upstream v8

    Original commit message:
        [Api] Add an idle time garbage collection callback flag to GCCallbackFlags.
    
        BUG=chromium:718484
    
        Review-Url: https://codereview.chromium.org/2867073002
        Cr-Commit-Position: refs/heads/master@{nodejs#45167}
    
    PR-URL: nodejs#13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hannespayer authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    f01016c View commit details
    Browse the repository at this point in the history
  16. v8: backport 4f82f1d948c from upstream v8

    Original commit message:
        [PATCH] Rename idle garbage collection callback flag.
    
        TBR=mlippautz@chromium.org
    
        Review-Url: https://codereview.chromium.org/2867863002
        Cr-Commit-Position: refs/heads/master@{nodejs#45173}
    
    PR-URL: nodejs#13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    hannespayer authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    aa2dfc4 View commit details
    Browse the repository at this point in the history
  17. v8: backport pieces from 18a26cfe174 from upstream v8

    Backport new virtual methods from 18a26cfe174
    ("Add memory protection API to ArrayBuffer::Allocator")
    
    PR-URL: nodejs#13217
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    psmarshall authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    2a1b8bf View commit details
    Browse the repository at this point in the history
  18. deps: cherry-pick a16c3c9 from upstream V8

    Original commit message:
    
        Expose the ValueSerializer data format version as a compile-time constant.
    
        BUG=chromium:704293
    
        Review-Url: https://codereview.chromium.org/2804643006
        Cr-Commit-Position: refs/heads/master@{nodejs#44945}
    jeremyroman authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    fb8aba0 View commit details
    Browse the repository at this point in the history
  19. deps: cherry-pick 866ee63 from upstream V8

    Original commit message:
    
        [string] Re-enable result caching for String.p.split
    
        Runtime::kStringSplit's result caching is only enabled when limit equals
        kMaxUInt32.
    
        BUG=v8:6463
    
        Review-Url: https://codereview.chromium.org/2923183002
        Cr-Commit-Position: refs/heads/master@{nodejs#45724}
    
    Fixes: nodejs#13445
    targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    5d5eb0b View commit details
    Browse the repository at this point in the history
  20. v8: fix debug builds on Windows

    Adds missing return which fixes debug builds on Windows
    
    Fixes: nodejs#13392
    Ref: https://codereview.chromium.org/2929993003/
    PR-URL: nodejs#13634
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    bzoz authored and targos committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    31142a7 View commit details
    Browse the repository at this point in the history
  21. deps: update V8 to 5.9.211.37

    PR-URL: nodejs#13790
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    targos authored and addaleax committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    147d8f1 View commit details
    Browse the repository at this point in the history
  22. deps: cherry-pick 3f4536894ac from V8 upstream

    Original commit message:
    
        d8: Make in process stack dumping optional
    
        Adds a flag (--disable-in-process-stack-traces) to not install
        signal handlers so that e.g. ASan signal handlers will work.
    
        This flag mirrors chromium's one.
    
        R=jochen@chromium.org
        BUG=chromium:716235
    
        Review-Url: https://codereview.chromium.org/2854173002
        Cr-Commit-Position: refs/heads/master@{nodejs#45142}
    
    PR-URL: nodejs#13985
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    oliverchang authored and addaleax committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    356af65 View commit details
    Browse the repository at this point in the history
  23. src: fix process.abort() interaction with V8

    Since V8 5.9 V8 installs a default signal handler for some signals
    when creating a default platform instance that prints a stack trace.
    
    However, Node already does the same thing, so it would seem like the
    two different stack traces would be printed; also, the V8 handler
    would lead to a `SIGSEGV` under some circumstances, rather than
    letting the abort continue normally.
    
    Resolve this by disabling V8’s signal handler by default.
    
    PR-URL: nodejs#13985
    Fixes: nodejs#13865
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    addaleax committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    e2ae710 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. deps: cherry-pick 6cb999b97b from V8 upstream

    Original commit message:
    
        Properly handle loads from global interceptor via prototype chain.
    
        ... when receiver is in dictionary mode.
    
        Bug: v8:6490
        Change-Id: Ic5a8d214adcc4efd4cb163cbc6b351c4e6b596af
        Reviewed-on: https://chromium-review.googlesource.com/559548
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Igor Sheludko <ishell@chromium.org>
        Cr-Commit-Position: refs/heads/master@{nodejs#46428}
    
    Ref: https://chromium.googlesource.com/v8/v8.git/+/6cb999b97b7953ebfd4aabf2e1f62bf405f21c69
    Fixes: nodejs#13804
    PR-URL: nodejs#14188
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    isheludko authored and addaleax committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    646eff0 View commit details
    Browse the repository at this point in the history