test: fix typo in test-cli-node-options.js #13558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
cli
|
CI: https://ci.nodejs.org/job/node-test-pull-request/8562/ Two fails seem unrelated. |
cjihrig
approved these changes
Jun 8, 2017
Trott
reviewed
Jun 8, 2017
| opt, expect, stdout); | ||
| assert(false, `Expected ${expect}`); | ||
| opt, want, stdout); | ||
| assert(false, `Expected ${want}`); |
There was a problem hiding this comment.
While we're in here, maybe change this to assert.fail(...) instead of assert(false, ...)?
`expect` was probably a typo, as it is a function and will always be `undefined` as JSON. The previous `test()` check infers it should be `want`.
|
|
hiroppy
approved these changes
Jun 9, 2017
aqrln
approved these changes
Jun 9, 2017
mhdawson
approved these changes
Jun 9, 2017
lpinca
approved these changes
Jun 10, 2017
|
Landed in 401a372 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jun 12, 2017
`expect` was probably a typo, as it is a function and will always be `undefined` as JSON. The previous `test()` check infers it should be `want`. PR-URL: #13558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 12, 2017
`expect` was probably a typo, as it is a function and will always be `undefined` as JSON. The previous `test()` check infers it should be `want`. PR-URL: #13558 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, cli
expectwas probably a typo, as it is a function and will always beundefinedas JSON.The previous
test()check infers it should bewant.cc @sam-github