Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use HTTPS URL for suggested upstream remote #13602

Merged
merged 0 commits into from
Jun 10, 2017
Merged

doc: use HTTPS URL for suggested upstream remote #13602

merged 0 commits into from
Jun 10, 2017

Conversation

seishun
Copy link
Contributor

@seishun seishun commented Jun 10, 2017

It's impossible to push to git:// URLs.

Fixes: #13600

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 10, 2017
@seishun seishun requested a review from refack June 10, 2017 18:39
@gibfahn
Copy link
Member

gibfahn commented Jun 10, 2017 •
edited
Loading

💯 , didn't realise this wasn't set to https.

@mscdex
Copy link
Contributor

mscdex commented Jun 10, 2017

LGTM

@seishun seishun closed this Jun 10, 2017
@seishun seishun merged commit 24e5b67 into nodejs:master Jun 10, 2017
@seishun seishun deleted the fix-upstream branch June 10, 2017 20:01
addaleax pushed a commit that referenced this pull request Jun 12, 2017
@seishun @addaleax
doc: use HTTPS URL for suggested upstream remote
52f5e3f 
It's impossible to push to git:// URLs.

PR-URL: #13602
Fixes: #13600
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@addaleax addaleax mentioned this pull request Jun 12, 2017
Merged
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@seishun @MylesBorins
doc: use HTTPS URL for suggested upstream remote
9fa7006 
It's impossible to push to git:// URLs.

PR-URL: #13602
Fixes: #13600
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@addaleax addaleax addaleax approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Landing Pull Requests" is incompatible with repo setup in CONTRIBUTING.md
6 participants
@seishun @gibfahn @mscdex @refack @addaleax @nodejs-github-bot