Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant mentions to error codes in doc/api/errors.md #13627

Closed
wants to merge 1 commit into from

Conversation

jklepatch
Copy link
Contributor

Fix this issue:
"Every description of each error code starts with one of two unnecessarily-verbose phrases that should probably be removed:"
https://github.com/nodejs/node/blob/master/doc/api/errors.md#nodejs-error-codes

  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

doc/api/errors.md

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jun 12, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. LGTM!

@mscdex
Copy link
Contributor

mscdex commented Jun 12, 2017

/cc @jasnell

tniessen pushed a commit that referenced this pull request Jun 14, 2017
PR-URL: #13627
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@tniessen
Copy link
Member

Landed in 2f34bf0 🎉 Thank you for your contribution. In the future, please try to follow our guidelines for commit messages. You might also want to configure git to automatically detect lines with trailing whitespace as this can cause problems when applying your changes.

@tniessen tniessen closed this Jun 14, 2017
tniessen added a commit to tniessen/node that referenced this pull request Jun 22, 2017
tniessen added a commit that referenced this pull request Jun 28, 2017
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax
Copy link
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

addaleax pushed a commit that referenced this pull request Jul 11, 2017
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax
Copy link
Member

@danbev @Trott @lpinca @TimothyGu @cjihrig Does any of you have the time to backport? This seems like a great candidate for backporting to avoid future conflicts.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 11, 2017
PR-URL: nodejs#13627
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Jul 11, 2017

Backport in #14175

addaleax pushed a commit that referenced this pull request Jul 12, 2017
PR-URL: #13627
Backport-PR-URL: #14175
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@addaleax addaleax mentioned this pull request Jul 18, 2017
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #13869
Refs: #13604
Refs: #13627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
PR-URL: #13627
Backport-PR-URL: #14175
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
PR-URL: #13627
Backport-PR-URL: #14175
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.