Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unneeded HandleScope usage #13859

Closed

Conversation

ezequielgarcia
Copy link
Contributor

These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

/cc @bnoordhuis

Checklist
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jun 21, 2017
@tniessen tniessen self-assigned this Jun 22, 2017
@tniessen
Copy link
Member

@bnoordhuis
Copy link
Member

There's a small typo in the commit log (s/unneded/unneeded/) and we don't usually capitalize words in the status line (s/Remove/remove/).

These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
@ezequielgarcia ezequielgarcia force-pushed the rm_extra_handle_scope branch from 2693843 to 174676a Compare June 22, 2017 11:18
@tniessen
Copy link
Member

tniessen commented Jun 28, 2017

New CI before merging: https://ci.nodejs.org/job/node-test-pull-request/8848/

@tniessen tniessen changed the title test: Remove unneded HandleScope usage test: remove unneeded HandleScope usage Jun 28, 2017
@tniessen
Copy link
Member

CI is as green as it will get today, landed in ea12038. Thank you for your first contribution! 🎉

@tniessen tniessen closed this Jun 28, 2017
tniessen pushed a commit that referenced this pull request Jun 28, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
addaleax pushed a commit that referenced this pull request Jun 29, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
@addaleax addaleax mentioned this pull request Jun 29, 2017
addaleax pushed a commit that referenced this pull request Jul 11, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
addaleax pushed a commit that referenced this pull request Jul 18, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
MylesBorins pushed a commit that referenced this pull request Aug 15, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
These methods are Javascript-accessible so they get an implicit
HandleScope. The extra scope is unneeded and can be dropped.

PR-URL: #13859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2017
This was referenced Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants