test: refactor test-crypto-pbkdf2 #13975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* re-order require() and crypto check per test writing guide * use common.mustNotCall() to confirm callback is not invoked
Trott
added
crypto
jasnell
approved these changes
Jun 29, 2017
lpinca
approved these changes
Jun 29, 2017
danbev
approved these changes
Jun 29, 2017
cjihrig
approved these changes
Jun 29, 2017
refack
approved these changes
Jun 29, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 2, 2017
* re-order require() and crypto check per test writing guide * use common.mustNotCall() to confirm callback is not invoked PR-URL: nodejs#13975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 48660fb |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
* re-order require() and crypto check per test writing guide * use common.mustNotCall() to confirm callback is not invoked PR-URL: nodejs#13975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
* re-order require() and crypto check per test writing guide * use common.mustNotCall() to confirm callback is not invoked PR-URL: #13975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
* re-order require() and crypto check per test writing guide * use common.mustNotCall() to confirm callback is not invoked PR-URL: #13975 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test crypto