test: http outgoing _renderHeaders #13981
Conversation
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
|
|
||
| const outHeadersKey = require('internal/http').outHeadersKey; |
There was a problem hiding this comment.
This will probably need to have // Flags: --expose-internal added on the line below 'use strict';
There was a problem hiding this comment.
is that automatically read by node, or is that for fellow developers? 😄
There was a problem hiding this comment.
It’s read by the test runner, so if you run it as make test or python tools/test.py parallel/test-http-outgoing-renderHeaders, it will automatically be used. If you want to run the test file manually as ./node test/parallel/test-http-outgoing-renderHeaders.js, you’ll also need to add the flag yourself.
| const http = require('http'); | ||
| const OutgoingMessage = http.OutgoingMessage; | ||
|
|
||
| const outgoingMessage = new OutgoingMessage(); |
There was a problem hiding this comment.
Can you isolate these tests using block scoping. That prevents the need for outgoingMessage, outgoingMessage2, etc. It also reduces the potential for the tests interacting with each other unintentionally.
There was a problem hiding this comment.
I've changed the code to use block scoping, it seemed a dirty solution without it, thanks for the advice!
| @@ -0,0 +1,47 @@ | |||
| 'use strict' | |||
| // Flags: --expose-internal | |||
There was a problem hiding this comment.
You were right I missed a s at the end. Thanks.
|
is there anything I should do to get this merged? |
|
@Peteyy we need to run the automatic test suite before this could land. For technical reasons that will only be possible tomorrow (2017-07-10). I'm set myself a calendar reminder. |
|
@refack any news since then? |
PR-URL: nodejs#13981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #13981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #13981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Improve http outgoing test coverage
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http-outgoing