test: mark test-fs-readdir-ucs2 flaky #13989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
approved these changes
Jun 29, 2017
|
+1 for fast-tracking |
|
CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/8875/ Landed in 47d1e12, fast tracked. |
joaocgreis
added a commit
that referenced
this pull request
Jun 29, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Just to see it pass (well, yellow) CI on |
Isn't that for Alpine? This is unrelated, the CI will remain yellow, which makes sense to me since |
Yes, right. 🤦♂️ |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
refack
added
the
flaky-test
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 21, 2017
PR-URL: #13989 Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in our CI infra makes
test-fs-readdir-ucs2fail every run on Raspberry Pi (ref: nodejs/build#774 (comment)).While we need to find a better solution, I suggest we mark the test as flaky to avoid having every run red because of this.
@nodejs/testing @nodejs/ctc any objection for fast tracking?
Ref: nodejs/build#774
Ref: #13986
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Test