N-API: Reuse ObjectTemplate used for napi_wrap() #13999

gabrielschulhof · 2017-06-30T10:40:09Z

V8 caches and does not subsequently release ObjectTemplate instances.
Thus, we need to store the ObjectTemplate from which we derive object
instances we use for napi_wrap() in a persistent in the napi_env.

Re nodejs/node-addon-api#70 (comment)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

N-API

gabrielschulhof · 2017-06-30T10:40:58Z

This means we will have one ObjectTemplate per N-API module, because we have one napi_env per N-API module.

gabrielschulhof · 2017-06-30T10:47:01Z

Whoops! Wrong template :) BRB

gabrielschulhof · 2017-06-30T10:56:03Z

Hmmm ... we actually use more than one ObjectTemplate. Need to store 'em all on the napi_env.

gabrielschulhof · 2017-06-30T11:08:04Z

OK, now we're good. Three ObjectTemplate instances stored on the napi_env. So, three ObjectTemplate instances per module. Granted, they're lazy, so an ObjectInstance is only created if

a module does any wrapping (not necessarily though often)
a module implements accessors (perhaps more rarely)
a module exports native functions (almost always)

bnoordhuis · 2017-06-30T11:21:57Z

src/node_api.cc

  v8::Local<v8::Object> wrapper =
-    wrapperTemplate->NewInstance(context).ToLocalChecked();
+    wrapper_template->NewInstance(context).ToLocalChecked();


Can you indent by 4 spaces?

V8 caches and does not subsequently release `ObjectTemplate` instances. Thus, we need to store the `ObjectTemplate` from which we derive object instances we use for `napi_wrap()` and function/accessor context in a persistent in the `napi_env`. nodejs/node-addon-api#70 (comment)

mhdawson

LGTM

mhdawson · 2017-07-06T15:59:52Z

CI run: https://ci.nodejs.org/job/node-test-pull-request/9010/

mhdawson · 2017-07-06T18:22:15Z

Landed as 29df1a8

V8 caches and does not subsequently release `ObjectTemplate` instances. Thus, we need to store the `ObjectTemplate` from which we derive object instances we use for `napi_wrap()` and function/accessor context in a persistent in the `napi_env`. nodejs/node-addon-api#70 (comment) PR-URL: #13999 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.co> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

addaleax · 2017-07-11T18:02:41Z

@gabrielschulhof @mhdawson Just so you know, if you don’t provide the subsystem in the commit message in lowercase the tooling won’t group it properly in the changelog – not a big deal, just something for the future. :)

gibfahn · 2017-07-11T23:00:46Z

if you don’t provide the subsystem in the commit message in lowercase the tooling won’t group it properly in the changelog – not a big deal, just something for the future. :)

If we don't have any uppercase subsystems (which I think is the case) then maybe core-validate-commit could check for that.

evanlucas · 2017-07-11T23:11:54Z

it checks for a certain set of subsystems, so it should have failed for that as well.

  ✖  29df1a87fa230bc86f460620173b9fedd2919f68
     ✔  0:0      skipping fixes-url                        fixes-url
     ✔  0:0      blank line after title                    line-after-title
     ✔  0:0      line-lengths are valid                    line-length
     ✔  0:0      metadata is at end of message             metadata-end
     ✔  0:0      reviewers are valid                       reviewers
     ✖  0:0      Invalid subsystem: "N-API"                subsystem
     ✔  0:0      Title is <= 50 columns.                   title-length

:]

V8 caches and does not subsequently release `ObjectTemplate` instances. Thus, we need to store the `ObjectTemplate` from which we derive object instances we use for `napi_wrap()` and function/accessor context in a persistent in the `napi_env`. nodejs/node-addon-api#70 (comment) PR-URL: #13999 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.co> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

V8 caches and does not subsequently release `ObjectTemplate` instances. Thus, we need to store the `ObjectTemplate` from which we derive object instances we use for `napi_wrap()` and function/accessor context in a persistent in the `napi_env`. nodejs/node-addon-api#70 (comment) PR-URL: nodejs#13999 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.co> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

V8 caches and does not subsequently release `ObjectTemplate` instances. Thus, we need to store the `ObjectTemplate` from which we derive object instances we use for `napi_wrap()` and function/accessor context in a persistent in the `napi_env`. nodejs/node-addon-api#70 (comment) Backport-PR-URL: #19447 PR-URL: #13999 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.co> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Jun 30, 2017

gabrielschulhof force-pushed the reuse-wrap-template branch from c2690c1 to 31f9c8a Compare June 30, 2017 11:05

gabrielschulhof force-pushed the reuse-wrap-template branch from 31f9c8a to 7715ba1 Compare June 30, 2017 11:13

bnoordhuis approved these changes Jun 30, 2017

View reviewed changes

gabrielschulhof force-pushed the reuse-wrap-template branch from 7715ba1 to 4ec417d Compare June 30, 2017 11:29

addaleax approved these changes Jun 30, 2017

View reviewed changes

cjihrig approved these changes Jun 30, 2017

View reviewed changes

jasnell approved these changes Jun 30, 2017

View reviewed changes

digitalinfinity approved these changes Jun 30, 2017

View reviewed changes

mhdawson approved these changes Jul 6, 2017

View reviewed changes

mhdawson closed this Jul 6, 2017

gabrielschulhof deleted the reuse-wrap-template branch July 6, 2017 18:39

addaleax mentioned this pull request Jul 11, 2017

v8.2.0 proposal #13744

Merged

MylesBorins added the dont-land-on-v6.x label Aug 15, 2017

MylesBorins mentioned this pull request Apr 16, 2018

v6.14.2 proposal #19996

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

N-API: Reuse ObjectTemplate used for napi_wrap() #13999

N-API: Reuse ObjectTemplate used for napi_wrap() #13999

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

bnoordhuis Jun 30, 2017

mhdawson left a comment

mhdawson commented Jul 6, 2017

mhdawson commented Jul 6, 2017

addaleax commented Jul 11, 2017

gibfahn commented Jul 11, 2017

evanlucas commented Jul 11, 2017

N-API: Reuse ObjectTemplate used for napi_wrap() #13999

N-API: Reuse ObjectTemplate used for napi_wrap() #13999

Conversation

gabrielschulhof commented Jun 30, 2017

Checklist

Affected core subsystem(s)

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

gabrielschulhof commented Jun 30, 2017

bnoordhuis Jun 30, 2017

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

mhdawson commented Jul 6, 2017

mhdawson commented Jul 6, 2017

addaleax commented Jul 11, 2017

gibfahn commented Jul 11, 2017

evanlucas commented Jul 11, 2017