Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check and fail inspector-cluster-port-clash #14074

Closed
wants to merge 2 commits into from
Closed

test: check and fail inspector-cluster-port-clash #14074

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d0d934
test: check and fail inspector-cluster-port-clash
danbev Jul 5, 2017
69a0efb
squash: add comment to replace check if moved
danbev Jul 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions test/known_issues/test-inspector-cluster-port-clash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Flags: --inspect=0
'use strict';
const common = require('../common');
const assert = require('assert');

// With the current behavior of Node.js (at least as late as 8.1.0), this
// test fails with the following error:
Expand All @@ -10,9 +11,13 @@ const common = require('../common');
//
// Refs: https://github.com/nodejs/node/issues/13343

common.skipIfInspectorDisabled();
if (process.config.variables.v8_enable_inspector === 0) {
// When the V8 inspector is disabled, using either --without-inspector or
// --without-ssl, this test will not fail which it is expected to do.
// The following fail will allow this test to be skipped by failing it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add something to this comment about replacing this block with common.skipIfInspectorDisabled() when/if this test is moved out of known_issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll add a comment about that.

assert.fail('skipping as V8 inspector is disabled');
}

const assert = require('assert');
const cluster = require('cluster');
const net = require('net');

Expand Down