Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: overriding inspector port #14140

Merged
merged 3 commits into from
Jul 14, 2017
Merged

cluster: overriding inspector port #14140

merged 3 commits into from
Jul 14, 2017

Commits on Jul 14, 2017

  1. doc: fixes in cluster.md 

    * Capitalization and punctuation.

* `setupMaster` contained info about `settings` which where incomplete.

PR-URL: nodejs#14140
Fixes: nodejs#8495
Fixes: nodejs#12941
Refs: nodejs#9659
Refs: nodejs#13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mutantcornholio @refack
    mutantcornholio authored and refack committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    ca5b0c4 View commit details
    Browse the repository at this point in the history

  2. test: reduce offset in test-inspector-port-cluster 

    10 ports for each test-case is too much.
Not enough ports for new test cases, considering ~100 ports per file.

PR-URL: nodejs#14140
Fixes: nodejs#8495
Fixes: nodejs#12941
Refs: nodejs#9659
Refs: nodejs#13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mutantcornholio @refack
    mutantcornholio authored and refack committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    592b0ed View commit details
    Browse the repository at this point in the history

  3. cluster: overriding inspector port 

    Added an option to override inspector port for workers using
`settings.inspectPort` will override default port incrementing behavior.
Also, using this option allows to set 0 port for the whole cluster.

PR-URL: nodejs#14140
Fixes: nodejs#8495
Fixes: nodejs#12941
Refs: nodejs#9659
Refs: nodejs#13761
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @mutantcornholio @refack
    mutantcornholio authored and refack committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    b430053 View commit details
    Browse the repository at this point in the history