Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async hooks rename #14152

Closed
wants to merge 4 commits into from
Closed

Async hooks rename #14152

wants to merge 4 commits into from

Commits on Jul 13, 2017

  1. async_hooks: rename internal emit functions

    There are two categories of emit functions in async_hooks, those used by
    c++ (native) and those used by JavaScript (script). Previously these
    were named N for native and S for script. Finally, there was an odd case
    where emitInitN was called just init. This makes it more explicit by
    using the names emitInitNative and emitInitScript. The other emit
    functions are also renamed.
    AndreasMadsen committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    82ca354 View commit details
    Browse the repository at this point in the history
  2. async_hooks: make AsyncResource match emitInit

    AsyncResource previously called emitInitNative. Since AsyncResource is
    just an abstraction on top of the emitEventScript functions, it should
    call emitInitScript instead.
    AndreasMadsen committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    e50fa6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be5dbc5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1125791 View commit details
    Browse the repository at this point in the history