Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: fix indentation nits #14224

Closed
wants to merge 1 commit into from
Closed

buffer: fix indentation nits #14224

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 13, 2017

Fix indentation issues that will be flagged by upcoming stricter
linting.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

buffer tools

@Trott
buffer: fix indentation nits
77b9375 
Fix indentation issues that will be flagged by upcoming stricter
linting.
@Trott Trott added buffer Issues and PRs related to the buffer subsystem. tools Issues and PRs related to the tools directory. labels Jul 13, 2017
@nodejs-github-bot nodejs-github-bot added the buffer Issues and PRs related to the buffer subsystem. label Jul 13, 2017
@Trott
Copy link
Member Author

Trott commented Jul 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9124/

@Trott
Copy link
Member Author

Trott commented Jul 17, 2017

Landed in e0340af

@Trott Trott closed this Jul 17, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jul 17, 2017
@Trott
buffer: fix indentation nits
e0340af 
Fix indentation issues that will be flagged by upcoming stricter
linting.

PR-URL: nodejs#14224
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

This doesn’t land cleanly on 8.x; if you can, please follow the guide and raise a backport PR, if you don’t think it’s worth it let me know and we’ll add the dont-land-on label.

@Trott
Copy link
Member Author

Trott commented Jul 24, 2017

This depends on #13976 which is semver-major, so I'm going to mark it as dont-land.

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@Trott Trott deleted the buffer-indent-fixes branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @addaleax @refack @jasnell @lpinca @targos @cjihrig @nodejs-github-bot