test: fix flaky test-net-can-reset-timeout #14257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to expedite this so that it doesn't trip us up during Code + Learn later. /cc @nodejs/testing @bengl @joyeecheung @addaleax @refack |
|
With this change: $ tools/test.py -j 92 --repeat 920 test/parallel/test-net-can-reset-timeout.js
[02:14|% 100|+ 920|- 0]: Done
$ To compare with before the change, see #14241 (comment). |
addaleax
reviewed
Jul 15, 2017
| // Remove this listener so it isn't called again if timeout happens again. | ||
| stream.removeListener('timeout', timeoutListener); | ||
| }); | ||
| stream.on('timeout', timeoutListener); |
There was a problem hiding this comment.
Just using .once instead seems a bit simpler?
refack
approved these changes
Jul 15, 2017
| // If `active` notices that it was previously removed (perhaps it timed out or | ||
| // something) it just does an 'inline append' which re-links the timer. | ||
| // Ref: https://github.com/nodejs/node-v0.x-archive/issues/481 | ||
|
|
||
| const net = require('net'); | ||
|
|
||
| const server = net.createServer(common.mustCall(function(stream) { | ||
| stream.setTimeout(100); |
|
@Trott I took the liberty of adding a comment with context, feel free to remove it, or whatever. |
cjihrig
approved these changes
Jul 16, 2017
Trott
force-pushed
the
fix-can-reset-timer
branch
from
f9936ed to
8ea652d
Compare
|
Switched to |
refack
approved these changes
Jul 16, 2017
You didn't like my comment or just didn't see it? // When you write to a socket, it causes 'Timer.active' to be called on it.
// If `active` notices that it was previously removed (perhaps it timed out or
// something) it just does an 'inline append' which re-links the timer.
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/481 |
hiroppy
approved these changes
Jul 16, 2017
I wasn't quite sure I understood it out of context. I thought reading the test was actually more clear than the comment, but that may say more about me than the comment? Thinking about it more, though, I think having a link to the issue is a good idea so I'll at least add that back in... |
Trott
force-pushed
the
fix-can-reset-timer
branch
from
8ea652d to
f9d1804
Compare
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 16, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: nodejs#14257 Fixes: nodejs#14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
|
Landed in 5d3609d |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
Use `.once()` rather than `.on()` for timeout listener. Add comment with URL for issue explaining the purpose of the test. (h/t refack) PR-URL: #14257 Fixes: #14241 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeoutcan fire more than once, so remove the listener after the first time. The test still checks for issue that the test was originally written for (nodejs/node-v0.x-archive#481).Fixes: #14241
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test net