Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-confcn]replace string concatenation with template literals #14269

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/addons-napi/test_reference/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function runTests(i, title, tests) {
try {
tests[i]();
} catch (e) {
console.error('Test failed: ' + title);
console.error(`Test failed: ${title}`);
throw e;
}
setImmediate(() => {
Expand Down
6 changes: 3 additions & 3 deletions test/async-hooks/test-signalwrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ assert.strictEqual(typeof signal1.triggerAsyncId, 'number');
checkInvocations(signal1, { init: 1 }, 'when SIGUSR2 handler is set up');

let count = 0;
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);

let signal2;

Expand All @@ -36,7 +36,7 @@ function onsigusr2() {
' signal1: when first SIGUSR2 handler is called for the first time');

// trigger same signal handler again
exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
} else {
// second invocation
checkInvocations(
Expand All @@ -61,7 +61,7 @@ function onsigusr2() {
signal2, { init: 1 },
'signal2: when second SIGUSR2 handler is setup');

exec('kill -USR2 ' + process.pid);
exec(`kill -USR2 ${process.pid}`);
}
}

Expand Down