test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

Helianthus21 · 2017-07-16T07:57:39Z

[JSConf CN Code&Learn]
Replace string concatenation in test/parallel/test-fs-watchfile.js with template literals.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

…atchfile.js

joyeecheung · 2017-07-16T08:01:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9152/

targos · 2017-07-16T08:01:34Z

test/parallel/test-fs-watchfile.js

@@ -67,7 +67,7 @@ fs.watchFile(enoentFile, {interval: 0}, common.mustCall(function(curr, prev) {
 // Watch events should callback with a filename on supported systems.
 // Omitting AIX. It works but not reliably.
 if (common.isLinux || common.isOSX || common.isWindows) {
-  const dir = common.tmpDir + '/watch';
+  const dir = `${common.tmpDir}/watch'`;


You forgot to remove the last quote.

joyeecheung

LGTM if CI is green

Trott

Will LGTM once that last quotation mark is removed. :-D

Helianthus21 · 2017-07-16T08:12:04Z

Sorry for my careless.

Trott

LGTM if CI is green. Thank you for the contribution!

benjamingr

Thanks for your contribution and welcome to the project :)

tniessen

I don't want to block this seeing the number of approvals, but this should really use path.join instead, see #14272 (comment)

refack · 2017-07-16T17:01:10Z

test/parallel/test-fs-watchfile.js

@@ -67,7 +67,7 @@ fs.watchFile(enoentFile, {interval: 0}, common.mustCall(function(curr, prev) {
 // Watch events should callback with a filename on supported systems.
 // Omitting AIX. It works but not reliably.
 if (common.isLinux || common.isOSX || common.isWindows) {
-  const dir = common.tmpDir + '/watch';
+  const dir = `${common.tmpDir}/watch`;


This is Ok.
But it would be much better to use path.join instead, see #14272 (comment)

vsemozhetbyt · 2017-07-16T21:36:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9175/

Trott · 2017-07-17T02:37:08Z

CI is green. I'm +0 on using path.join() instead. I'm fine with it the way it is, and using path.join() might be a marginal improvement.

Look for lots of "converting template literals to path.join" changes at the next Code + Learn. :-P

blade254353074 · 2017-07-17T14:51:42Z

@Trott Can you change the code? or only @Helianthus21 can do it?

tniessen · 2017-07-17T15:55:52Z

@blade254353074 We recommend to always enable "Allow edits from maintainers" which in fact allows us to make changes on our own. However, we usually do not do that without explicit permission of the PR author. In this case, replacing the template with path.join would eliminate all of @Helianthus21's changes, so I would prefer not to alter his / her code.

Helianthus21 · 2017-07-18T01:22:50Z

Hey guys, I have already used path.join() instead the template string literals.

refack

💯
Thank you very much!

tniessen

Thanks @Helianthus21!

PR-URL: #14287 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2017-07-19T20:08:31Z

Landed with a few nits fixed in 6a587ad.
Thank you!

PR-URL: #14287 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

test:replace string concatenation with template literals in test-fs-w…

4d76c6b

…atchfile.js

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017

joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017

targos reviewed Jul 16, 2017

View reviewed changes

joyeecheung approved these changes Jul 16, 2017

View reviewed changes

Trott requested changes Jul 16, 2017

View reviewed changes

test: remove the last quote

2ec6bf4

targos approved these changes Jul 16, 2017

View reviewed changes

Trott approved these changes Jul 16, 2017

View reviewed changes

gibfahn approved these changes Jul 16, 2017

View reviewed changes

benjamingr approved these changes Jul 16, 2017

View reviewed changes

cjihrig approved these changes Jul 16, 2017

View reviewed changes

tniessen approved these changes Jul 16, 2017

View reviewed changes

tniessen self-assigned this Jul 16, 2017

gireeshpunathil approved these changes Jul 16, 2017

View reviewed changes

tniessen reviewed Jul 16, 2017

View reviewed changes

refack reviewed Jul 16, 2017

View reviewed changes

test: use path.join to replace path string concatenation

ccdc806

refack approved these changes Jul 18, 2017

View reviewed changes

jasnell approved these changes Jul 18, 2017

View reviewed changes

tniessen approved these changes Jul 18, 2017

View reviewed changes

jasnell closed this Jul 19, 2017

addaleax mentioned this pull request Jul 24, 2017

v8.3.0 proposal #14452

Closed

addaleax mentioned this pull request Aug 2, 2017

v8.3.0 proposal #14594

Merged

MylesBorins added the dont-land-on-v6.x label Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

Helianthus21 commented Jul 16, 2017

joyeecheung commented Jul 16, 2017

targos Jul 16, 2017

joyeecheung left a comment

Trott left a comment

Helianthus21 commented Jul 16, 2017

Trott left a comment

benjamingr left a comment

tniessen left a comment •

edited

Loading

refack Jul 16, 2017

vsemozhetbyt commented Jul 16, 2017

Trott commented Jul 17, 2017

blade254353074 commented Jul 17, 2017

tniessen commented Jul 17, 2017

Helianthus21 commented Jul 18, 2017

refack left a comment

tniessen left a comment

jasnell commented Jul 19, 2017

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

test: replace string concatenation with template string literals in test-fs-watchfile.js #14287

Conversation

Helianthus21 commented Jul 16, 2017

Checklist

joyeecheung commented Jul 16, 2017

targos Jul 16, 2017

Choose a reason for hiding this comment

joyeecheung left a comment

Choose a reason for hiding this comment

Trott left a comment

Choose a reason for hiding this comment

Helianthus21 commented Jul 16, 2017

Trott left a comment

Choose a reason for hiding this comment

benjamingr left a comment

Choose a reason for hiding this comment

tniessen left a comment • edited Loading

Choose a reason for hiding this comment

refack Jul 16, 2017

Choose a reason for hiding this comment

vsemozhetbyt commented Jul 16, 2017

Trott commented Jul 17, 2017

blade254353074 commented Jul 17, 2017

tniessen commented Jul 17, 2017

Helianthus21 commented Jul 18, 2017

refack left a comment

Choose a reason for hiding this comment

tniessen left a comment

Choose a reason for hiding this comment

jasnell commented Jul 19, 2017

tniessen left a comment •

edited

Loading