-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: allow inspector to reopen with same port #14320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why the assertion was there before. LGTM assuming that the inspector correctly closes the socket.
That's tested above by |
CI: https://ci.nodejs.org/job/node-test-commit/11724/ CI was green except for macOS, which failed with:
which is #14747 |
Test checks that if you open the inspector with '0' (pick a random free port), close it, then reopen it, you get a different port. However this isn't necessarily true. PR-URL: nodejs#14320 Fixes: nodejs#14316 Refs: nodejs#14316 (comment) Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
23836a6
to
8780e1d
Compare
Test checks that if you open the inspector with '0' (pick a random free port), close it, then reopen it, you get a different port. However this isn't necessarily true. PR-URL: #14320 Fixes: #14316 Refs: #14316 (comment) Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Adding |
Test checks that if you open the inspector with '0' (pick a random free
port), close it, then reopen it, you get a different port. However this
isn't necessarily true.
Fixes: #14316
Refs: #14316 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test, inspector