Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6.x backport] test: harden test-dgram-bind-shared-ports #14327

Closed
wants to merge 1 commit into from
Closed

[v6.x backport] test: harden test-dgram-bind-shared-ports #14327

wants to merge 1 commit into from

Conversation

refack
Copy link
Contributor

@refack refack commented Jul 17, 2017

Ref: #13100

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,dgram,cluster

@refack
test: harden test-dgram-bind-shared-ports
5967e4b 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

PR-URL: nodejs#13100
Refs: nodejs#13055
Refs: nodejs#12999
Refs: nodejs#13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Jul 17, 2017
@refack refack mentioned this pull request Jul 17, 2017
Merged
3 tasks
@refack
Copy link
Contributor Author

refack commented Jul 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9197/

@mscdex mscdex added dgram Issues and PRs related to the dgram subsystem / UDP. cluster Issues and PRs related to the cluster subsystem. labels Jul 17, 2017
@refack refack mentioned this pull request Jul 17, 2017
Merged
4 tasks
@refack refack added the blocked PRs that are blocked by other issues or PRs. label Jul 17, 2017
@refack
Copy link
Contributor Author

refack commented Jul 17, 2017

Dependant on #12935 being backported

@MylesBorins
Copy link
Contributor

MylesBorins commented Aug 14, 2017 •
edited
Loading

landed in ac21bfd

MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@refack @MylesBorins
test: harden test-dgram-bind-shared-ports
ac21bfd 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 14, 2017
@refack @MylesBorins
test: harden test-dgram-bind-shared-ports
189dc42 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@refack @MylesBorins
test: harden test-dgram-bind-shared-ports
a1cef1f 
* add `mustCall` and `mustNotCall` to all callbacks
* added `known_issue` for port binding

Backport-PR-URL: #14327
PR-URL: #13100
Refs: #13055
Refs: #12999
Refs: #13526
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@refack refack deleted the backport-13100-to-v6.x branch October 24, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @MylesBorins @jasnell @mscdex @nodejs-github-bot