Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix minor typo in cluster.md #14353

Closed
wants to merge 1 commit into from
Closed

doc: fix minor typo in cluster.md #14353

wants to merge 1 commit into from

Conversation

lance
Copy link
Member

@lance lance commented Jul 18, 2017

Add a missing ' to example code.

Fixes: #14352

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Jul 18, 2017
@lance
Copy link
Member Author

lance commented Jul 19, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9232/

Unrelated failures on a single raspbian-wheezy instance

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 19, 2017
@lance
doc: fix minor typo in cluster.md
c5521fa 
Adds a missing `'` in code example.

PR-URL: nodejs#14353
Fixes: nodejs#14352
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@vsemozhetbyt
Copy link
Contributor

Landed in c5521fa

@Trott
Copy link
Member

Trott commented Jul 19, 2017

I assume this should be closed since it landed...

@Trott Trott closed this Jul 19, 2017
addaleax pushed a commit that referenced this pull request Jul 22, 2017
@lance @addaleax
doc: fix minor typo in cluster.md
e055255 
Adds a missing `'` in code example.

PR-URL: #14353
Fixes: #14352
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 24, 2017
@lance @Fishrock123
doc: fix minor typo in cluster.md
d2121ab 
Adds a missing `'` in code example.

PR-URL: #14353
Fixes: #14352
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@addaleax addaleax mentioned this pull request Jul 24, 2017
Closed
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lance @vsemozhetbyt @Trott @lpinca @cjihrig @gibfahn @MylesBorins @nodejs-github-bot