V6.x backport 13531 docs #14413
Closed
V6.x backport 13531 docs #14413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Backport of the documentation from nodejs#13531 that did not land in 2fb1381. PR-URL: nodejs#13553 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
sam-github
force-pushed
the
v6.x-backport-13531-docs
branch
from
c832efa to
3dd5282
Compare
refack
approved these changes
Jul 21, 2017
|
@MylesBorins @nodejs/lts I'm not sure what the metadata should be. I left the metadata from the original PR in the commit, but that seems weird. Have we agreed on a scheme for what metadata should look like on backport PRs? |
|
@sam-github we agreed to keep all original meta data (including reviews) and add a new field |
|
I've gone ahead and rebased this back into the original cherry-pick 59eb761 |
gibfahn
approved these changes
Jul 22, 2017
|
My bad @MylesBorins, didn't realise you meant you'd rebased and landed on v6.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of docs from #13531
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc