async_hooks: remove deprecated APIs #14414

addaleax · 2017-07-21T17:37:35Z

These APIs were introduced during the lifetime of Node 8 in an experimental API and should safely be removable in Node 9+.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

async_hooks

/cc @nodejs/async_hooks

These APIs were introduced during the lifetime of Node 8 in an experimental API and should safely be removable in Node 9+.

Trott

LGTM if CI is green

addaleax · 2017-07-21T18:17:02Z

@refack We only label PRs v?.x if they target v?.x(-staging), if you want something done by a certain date there’s the Milestone feature for that :) But really, neither of that is necessary, this is going to land early enough (and even if it doesn’t there is not much harm in that).

AndreasMadsen

LGTM. I thought we had more :)

refack · 2017-07-21T19:02:00Z

@refack We only label PRs v?.x if they target v?.x(-staging), if you want something done by a certain date there’s the Milestone feature for that :) But really, neither of that is necessary, this is going to land early enough (and even if it doesn’t there is not much harm in that).

It was just @jasnell's request 🤷‍♂️

For any PR that needs to land for 9.x, I would appreciate if you would assign it to the 9.x milestone for easier tracking.

refack · 2017-07-21T19:02:26Z

It was just @jasnell's request 🤷‍♂️

For any PR that needs to land for 9.x, I would appreciate if you would assign it to the 9.x milestone for easier tracking.

Ohh I just misread that...

addaleax · 2017-07-21T19:20:58Z

@AndreasMadsen We kind of do, we did things the other way around for #14109 and didn’t even introduce the deprecated methods into master.

@refack Like I said, I don’t think this qualifies as a PR that needs to land for 9.x. That’s probably just splitting hairs at this point but it might become more relevant moving closer towards the 9.x branch cutoff. ¯\_(ツ)_/¯

AndreasMadsen · 2017-07-21T19:39:01Z

I'm +1 adding this to the 9.0.0 milestone. Most likely it is not going to make any difference.

When deprecated API isn't removed it tends to become used, which can be a problem. I like how we are handling the experimanal label in async_hooks: try to be backward compatible in semver-minor but remove deprecated API in next major release.

refack · 2017-07-21T19:43:16Z

I like how we are handling the experimanal label in async_hooks: try to be backward compatible in semver-minor but remove deprecated API in next major release.

@refack Like I said, I don’t think this qualifies as a PR that needs to land for 9.x. That’s probably just splitting hairs at this point but it might become more relevant moving closer towards the 9.x branch cutoff. ¯_(ツ)_/¯

I'm only bringing this up because it's sort of a "test case", and I'm definitely splitting hairs here, but IMHO this PR should be dont-land-on-v8.x and not semver-major. Obviously the only difference is the need for 2 (excluding @addaleax) CTC members' approval.
The reason is that async-hooks is experimental...

trevnorris · 2017-07-21T23:34:13Z

LGTM

addaleax · 2017-07-26T18:05:48Z

CI: https://ci.nodejs.org/job/node-test-commit/11384/

addaleax · 2017-07-27T18:03:32Z

Landed in d731369

These APIs were introduced during the lifetime of Node 8 in an experimental API and should safely be removable in Node 9+. PR-URL: #14414 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>

* **async_hooks** * Older experimental `async_hooks` APIs have been removed [[`d731369b1d`](d731369b1d)] **(SEMVER-MAJOR)** [#14414](#14414) * **Errors** * Multiple built in modules have been migrated to use static error codes * **Domains** * The long deprecated `.dispose()` method has been removed [[`602fd36d95`](602fd36d95)] **(SEMVER-MAJOR)** [#15412](#15412) * **File system** * `fs.ReadStream` and `fs.WriteStream` now make use of `.destroy()` [[`e5c290bed9`](e5c290bed9)] **(SEMVER-MAJOR)** [#15407](#15407) * `fs` callbacks are now invoked with an undefined `this` context [[`2249234fee`](2249234fee)] **(SEMVER-MAJOR)** [#14645](#14645) * **HTTP** * Socket timeout is set when the socket connects [[`10be20a0e8`](10be20a0e8)] **(SEMVER-MAJOR)** [#8895](#8895) * A bug causing the request `error` event to fire twice has been fixed [[`620ba41694`](620ba41694)] **(SEMVER-MAJOR)** [#14659](#14659) * The `pipe` method on `OutgoingMessage` has been disabled [[`156549d8ff`](156549d8ff)] **(SEMVER-MAJOR)** [#14358](#14358) * **HTTP/2** * The `--expose-http2` command-line argument is no longer required [[`f55ee6e24a`](f55ee6e24a)] **(SEMVER-MAJOR)** [#15535](#15535) * **Internationalization** * The `Intl.v8BreakIterator` class has been removed [[`668ad44922`](668ad44922)] **(SEMVER-MAJOR)** [#15238](#15238) * **OS** * `os.EOL` is now read-only [[`f6caeb9526`](f6caeb9526)] **(SEMVER-MAJOR)** [#14622](#14622) * **Process** * It is now possible to pass additional flags to `dlopen` [[`5f22375922`](5f22375922)] **(SEMVER-MAJOR)** [#12794](#12794) * **Timers** * Using a timeout duration larger than 32-bits will now emit a warning [[`ce3586da31`](ce3586da31)] **(SEMVER-MAJOR)** [#15627](#15627) * **TLS** * `parseCertString` has been deprecated [[`468110b327`](468110b327)] **(SEMVER-MAJOR)** [#14249](#14249) * Type-checking for `key`, `cert`, and `ca` options has been added [[`a7dccd040d`](a7dccd040d)] **(SEMVER-MAJOR)** [#14807](#14807)

* Older experimental APIs have been removed. [[`d731369b1d`](d731369b1d)] [#14414](#14414) * **Errors** * Improvements have been made to `buffer` module error messages. * The assignment of static error codes to Node.js error continues: * `buffer` * `child_process` * `console` * `crypto` * `dns` * `events` * `fs` * `http` * `inspector` * `net` * `path` * `process` * `querystring` * `readline` * `repl` * `streams` * `string_decoder` * `timers` * `tls` * `url` * `util` * `v8` * `zlib` * **Child Processes** * Errors are emitted on process nextTick. * **Domains** * The long-deprecated `.dispose()` method has been removed. * **fs** * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`. * `fs` module callbacks are now invoked with an undefined context. * **HTTP/1** * A 400 Bad Request response will now be sent when parsing fails. * Socket timeout will be set when the socket connects. * A bug causing the request `'error'` event to fire twice was fixed. * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`. * **Intl** * The deprecated `Intl.v8BreakIterator` has been removed. * **Modules** * The `require.resolve()` method now supports using custom lookup paths. * **OS** * The `os.EOL` property is now read-only. * **Timers** * `setTimeout()` will emit a warning if the timeout is larger that the maximum 32-bit unsigned integer. * **Util** * `TextEncoder` and `TextDecoder` are no longer experimental.

* Older experimental APIs have been removed. [[`d731369b1d`](d731369b1d)] [#14414](#14414) * **Errors** * Improvements have been made to `buffer` module error messages. * The assignment of static error codes to Node.js error continues: * `buffer` * `child_process` * `console` * `crypto` * `dns` * `events` * `fs` * `http` * `inspector` * `net` * `path` * `process` * `querystring` * `readline` * `repl` * `streams` * `string_decoder` * `timers` * `tls` * `url` * `util` * `v8` * `zlib` * **Child Processes** * Errors are emitted on process nextTick. * **Domains** * The long-deprecated `.dispose()` method has been removed. * **fs** * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`. * `fs` module callbacks are now invoked with an undefined context. * **HTTP/1** * A 400 Bad Request response will now be sent when parsing fails. * Socket timeout will be set when the socket connects. * A bug causing the request `'error'` event to fire twice was fixed. * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`. * **Intl** * The deprecated `Intl.v8BreakIterator` has been removed. * **Modules** * The `require.resolve()` method now supports using custom lookup paths. * **OS** * The `os.EOL` property is now read-only. * **Timers** * `setTimeout()` will emit a warning if the timeout is larger that the maximum 32-bit unsigned integer.

* Older experimental APIs have been removed. [[`d731369b1d`](nodejs/node@d731369b1d)] [#14414](nodejs/node#14414) * **Errors** * Improvements have been made to `buffer` module error messages. * The assignment of static error codes to Node.js error continues: * `buffer` * `child_process` * `console` * `crypto` * `dns` * `events` * `fs` * `http` * `inspector` * `net` * `path` * `process` * `querystring` * `readline` * `repl` * `streams` * `string_decoder` * `timers` * `tls` * `url` * `util` * `v8` * `zlib` * **Child Processes** * Errors are emitted on process nextTick. * **Domains** * The long-deprecated `.dispose()` method has been removed. * **fs** * The `fs.ReadStream` and `fs.WriteStream` classes now use `destroy()`. * `fs` module callbacks are now invoked with an undefined context. * **HTTP/1** * A 400 Bad Request response will now be sent when parsing fails. * Socket timeout will be set when the socket connects. * A bug causing the request `'error'` event to fire twice was fixed. * HTTP clients may now use generic `Duplex` streams in addition to `net.Socket`. * **Intl** * The deprecated `Intl.v8BreakIterator` has been removed. * **Modules** * The `require.resolve()` method now supports using custom lookup paths. * **OS** * The `os.EOL` property is now read-only. * **Timers** * `setTimeout()` will emit a warning if the timeout is larger that the maximum 32-bit unsigned integer.

async_hooks: remove deprecated APIs

af8505b

These APIs were introduced during the lifetime of Node 8 in an experimental API and should safely be removable in Node 9+.

addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 21, 2017

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. async_wrap c++ Issues and PRs that require attention from people who are familiar with C++. labels Jul 21, 2017

Trott approved these changes Jul 21, 2017

View reviewed changes

refack approved these changes Jul 21, 2017

View reviewed changes

refack mentioned this pull request Jul 21, 2017

Tracking Issue: Node.js 9.0.0 #14391

Closed

refack added the v9.x label Jul 21, 2017

addaleax removed the v9.x label Jul 21, 2017

AndreasMadsen approved these changes Jul 21, 2017

View reviewed changes

refack added this to the 9.0.0 milestone Jul 21, 2017

cjihrig approved these changes Jul 21, 2017

View reviewed changes

tniessen approved these changes Jul 26, 2017

View reviewed changes

addaleax closed this Jul 27, 2017

addaleax deleted the async-hooks-remove-deprecated-apis branch July 27, 2017 18:03

jasnell mentioned this pull request Oct 30, 2017

Proposal: 2017-10-31, Version 9.0.0 (Current) #15135

Merged

tniessen added the deprecations Issues and PRs related to deprecations. label Sep 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

async_hooks: remove deprecated APIs #14414

async_hooks: remove deprecated APIs #14414

addaleax commented Jul 21, 2017 •

edited

Loading

Trott left a comment

addaleax commented Jul 21, 2017

AndreasMadsen left a comment

refack commented Jul 21, 2017

refack commented Jul 21, 2017

addaleax commented Jul 21, 2017 •

edited

Loading

AndreasMadsen commented Jul 21, 2017

refack commented Jul 21, 2017

trevnorris commented Jul 21, 2017

addaleax commented Jul 26, 2017

addaleax commented Jul 27, 2017

async_hooks: remove deprecated APIs #14414

async_hooks: remove deprecated APIs #14414

Conversation

addaleax commented Jul 21, 2017 • edited Loading

Checklist

Affected core subsystem(s)

Trott left a comment

Choose a reason for hiding this comment

addaleax commented Jul 21, 2017

AndreasMadsen left a comment

Choose a reason for hiding this comment

refack commented Jul 21, 2017

refack commented Jul 21, 2017

addaleax commented Jul 21, 2017 • edited Loading

AndreasMadsen commented Jul 21, 2017

refack commented Jul 21, 2017

trevnorris commented Jul 21, 2017

addaleax commented Jul 26, 2017

addaleax commented Jul 27, 2017

addaleax commented Jul 21, 2017 •

edited

Loading

addaleax commented Jul 21, 2017 •

edited

Loading