Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-benchmark-timers #14464

Closed
wants to merge 1 commit into from
Closed

test: refactor test-benchmark-timers #14464

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 24, 2017

  • add type option to reduce combinations of benchmarks run (saves
    about 15% on run duration of test on my local machine)
  • alphabetize options
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark timers

@Trott
test: refactor test-benchmark-timers
0d17cb3 
* add `type` option to reduce combinations of benchmarks run (saves
  about 15% on run duration of test on my local machine)
* alphabetize options
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Jul 24, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 24, 2017
@Trott
Copy link
Member Author

Trott commented Jul 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9358/

Trott added a commit to Trott/io.js that referenced this pull request Jul 27, 2017
@Trott
test: refactor test-benchmark-timers
d3e07e3 
* add `type` option to reduce combinations of benchmarks run (saves
  about 15% on run duration of test on my local machine)
* alphabetize options

PR-URL: nodejs#14464
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 27, 2017

Landed in d3e07e3

@Trott Trott closed this Jul 27, 2017
addaleax pushed a commit that referenced this pull request Jul 27, 2017
@Trott @addaleax
test: refactor test-benchmark-timers
91b6ba1 
* add `type` option to reduce combinations of benchmarks run (saves
  about 15% on run duration of test on my local machine)
* alphabetize options

PR-URL: #14464
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleax addaleax mentioned this pull request Aug 2, 2017
Merged
@Trott Trott deleted the bench-time-opt branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @Fishrock123 @cjihrig @MylesBorins @nodejs-github-bot