doc: fix minor typos in net.md #14502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
refack
approved these changes
Jul 26, 2017
doc/api/net.md
Outdated
| @@ -386,7 +386,7 @@ Creates a new socket object. | |||
| for details. Defaults to `false`. | |||
| * `readable` {boolean} Allow reads on the socket when a `fd` is passed, | |||
| otherwise ignored. Defaults to `false`. | |||
| * `writable` {boolean} Allow reads on the socket when a `fd` is passed, | |||
| * `writable` {boolean} Allow writes on the socket when a `fd` is passed, | |||
There was a problem hiding this comment.
Both placed should be an `fd`
There was a problem hiding this comment.
@refack Thanks! I fixed with Line: 235.
There was a problem hiding this comment.
@refack pardon my ignorance but why?
There was a problem hiding this comment.
I suppose it depends on whether you read it as "an ef dee" or "a file descriptor."
vsemozhetbyt
approved these changes
Jul 26, 2017
About writable, not 'reads' but 'writes' is correct. And also, add parentheses because server.getConnections is function.
lpinca
approved these changes
Jul 26, 2017
addaleax
approved these changes
Jul 30, 2017
|
Landed in e95aceb, thank you a lot! |
addaleax
pushed a commit
that referenced
this pull request
Jul 30, 2017
About writable, not 'reads' but 'writes' is correct. And also, add parentheses because server.getConnections is function. PR-URL: #14502 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 1, 2017
About writable, not 'reads' but 'writes' is correct. And also, add parentheses because server.getConnections is function. PR-URL: #14502 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos and add missing parentheses to
server.getConnectionsfunction.Checklist
Affected core subsystem(s)
doc