test: improve error logging for inspector test #14508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
inspector
nodejs-github-bot
added
dont-land-on-v4.x
inspector
refack
reviewed
Jul 27, 2017
test/parallel/test-repl.js
Outdated
| @@ -414,7 +414,10 @@ function error_test() { | |||
| expect: `${prompt_multiline}'foo \\n'\n${prompt_unix}` }, | |||
| // Whitespace is not evaluated. | |||
| { client: client_unix, send: ' \t \n', | |||
| expect: prompt_unix } | |||
| expect: prompt_unix }, | |||
There was a problem hiding this comment.
@refack No, it's not. That's an error on my part. Will remove it. It's from an unrelated PR I was testing.
There was a problem hiding this comment.
I recognized the ... REPL test 😉
cjihrig
approved these changes
Jul 27, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. Refs: nodejs#14507
|
Rebased, resolved merge conflict, force pushed. |
lpinca
approved these changes
Jul 27, 2017
|
Since this test fails (per #14507) on CI pretty frequently, I'd like to fast-track this to get better information about how it's failing. Does that seem reasonable? @nodejs/testing |
|
Seems reasonable to me. |
|
Landed in bfb4f42 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 29, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: nodejs#14508 Ref: nodejs#14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 29, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If JSON.parse() fails, print a message showing the JSON that failed to
parse. This is to help with debugging a current test failure on CI.
Refs: #14507
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test inspector