zlib: fix interaction of flushing and needDrain #14527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
lts-watch-v4.x
zlib
|
Excellent, that was quick! The solution looks good and satisfies the original intention of #3534. I wouldn't be able to check it against the original SSE code until Mon, but with those tests passing then I can't see any reason it wouldn't also be resolved, so don't let that block this. |
Fishrock123
reviewed
Jul 28, 2017
| }); | ||
| } | ||
|
|
||
| (async function() { |
There was a problem hiding this comment.
fancy! I wasn't aware this was possible...
cjihrig
approved these changes
Jul 28, 2017
addaleax
force-pushed
the
zlib-flush-needdrain
branch
from
cf9e75e to
ff2dc30
Compare
jasnell
approved these changes
Jul 31, 2017
|
Landed in 717a138 (and resisted the urge to replace |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 1, 2017
Fixes: nodejs#14523 PR-URL: nodejs#14527 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
|
This is going to need manual backports to both v4.x and v6.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14523
I’d appreciate a review from @aaliddell who has obviously given this some thought.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib