Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Backport http test improvements #14583

Closed
wants to merge 1 commit into from
Closed

[8.x] Backport http test improvements #14583

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Aug 1, 2017

Backport of #14315 to 8.x-staging

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@jasnell
test: improvements to various http tests
4cddc05 
* Add common/countdown utility
* Numerous improvements to http tests

PR-URL: nodejs#14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Aug 1, 2017
@jasnell jasnell requested a review from addaleax August 1, 2017 22:55
addaleax
addaleax approved these changes Aug 1, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

addaleax pushed a commit that referenced this pull request Aug 1, 2017
@jasnell @addaleax
test: improvements to various http tests
b1fef05 
* Add common/countdown utility
* Numerous improvements to http tests

Backport-PR-URL: #14583
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #14315
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@addaleax
Copy link
Member

addaleax commented Aug 1, 2017

Landed in b1fef05

@addaleax addaleax closed this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @addaleax @nodejs-github-bot