doc: erase unneeded eslint-plugin-markdown comment #14598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-plugin-markdown comments affect only a code block below them, so there is no need to cancel them for the rest code blocks. Refs: https://github.com/eslint/eslint-plugin-markdown#configuration-comments
nodejs-github-bot
added
console
|
Linter CI: https://ci.nodejs.org/job/node-test-linter/10901/ (green) |
lpinca
approved these changes
Aug 2, 2017
benjamingr
approved these changes
Aug 3, 2017
tniessen
approved these changes
Aug 3, 2017
jasnell
approved these changes
Aug 3, 2017
|
Landed in d41423f |
vsemozhetbyt
added a commit
that referenced
this pull request
Aug 3, 2017
eslint-plugin-markdown comments affect only a code block below them, so there is no need to cancel them for the rest code blocks. PR-URL: #14598 Refs: https://github.com/eslint/eslint-plugin-markdown#configuration-comments Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 7, 2017
eslint-plugin-markdown comments affect only a code block below them, so there is no need to cancel them for the rest code blocks. PR-URL: #14598 Refs: https://github.com/eslint/eslint-plugin-markdown#configuration-comments Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
console, doc, tools
eslint-plugin-markdowncomments affect only a code block below them, so there is no need to cancel them for the rest code blocks.Refs: https://github.com/eslint/eslint-plugin-markdown#configuration-comments