Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: remove unused parameters #14640

Closed
wants to merge 1 commit into from
Closed

benchmark: remove unused parameters #14640

wants to merge 1 commit into from

Conversation

nishijayaraj
Copy link
Contributor

Functions onOnline and onMessage in benchmark/cluster/echo.js
had unused parameters. They were removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nishijayaraj
benchmark: remove unused parameters
2fcc9d9 
Functions onOnline and onMessage in benchmark/cluster/echo.js
had unused parameters. They were removed.
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. cluster Issues and PRs related to the cluster subsystem. labels Aug 5, 2017
@refack
Copy link
Contributor

refack commented Aug 5, 2017 •
edited
Loading

So even in TF&I having the callback's signature match the call is a little bit more performant, so for function onOnline(msg) onMessage IMHO the formal argument should stay, but renamed (my preference is _ , but I yield to the OP's).
Ref: #14137

lpinca
lpinca approved these changes Aug 5, 2017
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The little performance diff does not affect benchmark results.

@Trott
Copy link
Member

Trott commented Aug 8, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9540/

jasnell pushed a commit that referenced this pull request Aug 8, 2017
@nishijayaraj @jasnell
benchmark: remove unused parameters
e67220e 
Functions onOnline and onMessage in benchmark/cluster/echo.js
had unused parameters. They were removed.

PR-URL: #14640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 8, 2017

Landed in e67220e

@jasnell jasnell closed this Aug 8, 2017
addaleax pushed a commit that referenced this pull request Aug 10, 2017
@nishijayaraj @addaleax
benchmark: remove unused parameters
574cc37 
Functions onOnline and onMessage in benchmark/cluster/echo.js
had unused parameters. They were removed.

PR-URL: #14640
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. cluster Issues and PRs related to the cluster subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nishijayaraj @refack @Trott @jasnell @lpinca @tniessen @BridgeAR @MylesBorins @nodejs-github-bot