Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix http2 sample code in http2.md #14667

Closed
wants to merge 1 commit into from
Closed

doc: fix http2 sample code in http2.md #14667

wants to merge 1 commit into from

Conversation

kakts
Copy link
Contributor

@kakts kakts commented Aug 7, 2017 •
edited
Loading

Fixed http2 doc.
There were some mistakes of the sample codes in doc/http2.md

Please check this PR and merge this.

changes
  • fix http2 sample code used in doc/http2.md
Checklist
Affected core subsystem(s)

doc,http2

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 7, 2017
refack
refack approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy and paste FTL

@refack
Copy link
Contributor

refack commented Aug 7, 2017

https://ci.nodejs.org/job/node-test-linter/10992/

@addaleax
Copy link
Member

Landed in 0eb7268, thank you for the PR!

@addaleax addaleax closed this Aug 10, 2017
addaleax pushed a commit that referenced this pull request Aug 10, 2017
@kakts @addaleax
doc: fix http2 sample code for http2.md
0eb7268 
PR-URL: #14667
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 13, 2017
@kakts @jasnell
doc: fix http2 sample code for http2.md
ede1161 
PR-URL: nodejs#14667
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Aug 14, 2017
@kakts @addaleax
doc: fix http2 sample code for http2.md
af85b6e 
PR-URL: #14667
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax addaleax mentioned this pull request Aug 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@kakts @refack @addaleax @jasnell @evanlucas @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot