Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check crypto before requiring tls module #14708

Closed
wants to merge 1 commit into from

Commits on Aug 9, 2017

  1. test: check crypto before requiring tls module

    test-tls-session-cache currently fails if built --without-ssl:
    internal/util.js:82
        throw new errors.Error('ERR_NO_CRYPTO');
        ^
    
    Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
    support
        at Object.assertCrypto (internal/util.js:82:11)
        at tls.js:26:14
        at NativeModule.compile (bootstrap_node.js:586:7)
        at Function.NativeModule.require (bootstrap_node.js:531:18)
        at Function.Module._load (module.js:449:25)
        at Module.require (module.js:517:17)
        at require (internal/module.js:11:18)
        at Object.<anonymous>
    (/node/test/parallel/test-tls-session-cache.js:26:13)
        at Module._compile (module.js:573:30)
        at Object.Module._extensions..js (module.js:584:10)
    
    The test has a crypto check but it come after the require of the tls
    module.
    
    This commit moves the crypto check to come before the require of tls and
    allows the test to pass.
    danbev committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    3126e57 View commit details
    Browse the repository at this point in the history