Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix docs style #14711

Closed
wants to merge 2 commits into from
Closed

doc: fix docs style #14711

wants to merge 2 commits into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Aug 9, 2017 •
edited
Loading

Summary

Once this PR is landed and no markdown lint warning found anymore, I will ship #12756 finally.

Change list

intl.md

  • L43: Add missing final pipe in table fence
  • L45: Add missing final pipe in table fence
  • L46: Add missing final pipe in table fence
  • L47: Add missing final pipe in table fence
  • L48: Add missing final pipe in table fence
  • L49: Add missing final pipe in table fence
  • L50: Add missing final pipe in table fence
  • L51: Add missing final pipe in table fence
  • L52: Add missing final pipe in table fence
  • L53: Add missing final pipe in table fence
  • L54: Add missing final pipe in table fence
  • L55: Add missing final pipe in table fence

util.md

  • L582: Cell should be padded
  • L589: Cell should be padded
  • L590: Cell should be padded
  • L600: Cell should be padded
  • L622: Cell should be padded
Checklist
  • make -j4 test
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 9, 2017
@watilde watilde force-pushed the feature/docs-lint-fix branch 2 times, most recently from 05f9ae6 to 5809435 Compare August 9, 2017 09:15
@watilde
Copy link
Member Author

watilde commented Aug 9, 2017

Lint ci: https://ci.nodejs.org/job/node-test-linter/11053/

@tniessen tniessen mentioned this pull request Aug 9, 2017
Merged
3 tasks
@refack
Copy link
Contributor

refack commented Aug 9, 2017

@watilde #14707 (I invited you to review it)
Let's split this up, I'll take out intl.md, and util.md since I like your fixes better, and you have a look at my http2.md and n-api.md

@watilde watilde changed the title Feature/docs lint fix doc: fix docs style Aug 9, 2017
@watilde
Copy link
Member Author

watilde commented Aug 9, 2017

@refack Wow nice work! I just noticed yours after I opened this PR, I should have a look.
Then I will take http2.md and n-api.md as you said( correct me if I'm misunderstanding), thanks!

@refack
Copy link
Contributor

refack commented Aug 9, 2017

I meant keep intl.md, and util.md here, and I'll revert them in #14707

refack
refack approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intl.md, and util.md LGTM

watilde added 2 commits August 13, 2017 19:57
@watilde
doc: fix docs style in intl.md
a360b2e 
Summary
  + L43: Add missing final pipe in table fence
  + L45: Add missing final pipe in table fence
  + L46: Add missing final pipe in table fence
  + L47: Add missing final pipe in table fence
  + L48: Add missing final pipe in table fence
  + L49: Add missing final pipe in table fence
  + L50: Add missing final pipe in table fence
  + L51: Add missing final pipe in table fence
  + L52: Add missing final pipe in table fence
  + L53: Add missing final pipe in table fence
  + L54: Add missing final pipe in table fence
  + L55: Add missing final pipe in table fence
@watilde
doc: fix docs style in util.md
af54bbc 
Summary
  + L582: Cell should be padded
  + L589: Cell should be padded
  + L590: Cell should be padded
  + L600: Cell should be padded
  + L622: Cell should be padded
@watilde watilde force-pushed the feature/docs-lint-fix branch from 5809435 to af54bbc Compare August 13, 2017 17:58
@watilde
Copy link
Member Author

watilde commented Aug 13, 2017

Cherry-picked my commits related to only intl.md/util.md, and rebased.

@watilde
Copy link
Member Author

watilde commented Aug 13, 2017

lint ci: https://ci.nodejs.org/job/node-test-linter/11143/

@watilde
Copy link
Member Author

watilde commented Aug 13, 2017

Landed in 003ba0b and 7294f57. Thanks.

@watilde watilde closed this Aug 13, 2017
watilde added a commit that referenced this pull request Aug 13, 2017
@watilde
doc: fix docs style in intl.md
003ba0b 
Summary
  + L43: Add missing final pipe in table fence
  + L45: Add missing final pipe in table fence
  + L46: Add missing final pipe in table fence
  + L47: Add missing final pipe in table fence
  + L48: Add missing final pipe in table fence
  + L49: Add missing final pipe in table fence
  + L50: Add missing final pipe in table fence
  + L51: Add missing final pipe in table fence
  + L52: Add missing final pipe in table fence
  + L53: Add missing final pipe in table fence
  + L54: Add missing final pipe in table fence
  + L55: Add missing final pipe in table fence

PR-URL: #14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
watilde added a commit that referenced this pull request Aug 13, 2017
@watilde
doc: fix docs style in util.md
7294f57 
Summary
  + L582: Cell should be padded
  + L589: Cell should be padded
  + L590: Cell should be padded
  + L600: Cell should be padded
  + L622: Cell should be padded

PR-URL: #14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 13, 2017
@watilde @addaleax
doc: fix docs style in intl.md
0de63e6 
Summary
  + L43: Add missing final pipe in table fence
  + L45: Add missing final pipe in table fence
  + L46: Add missing final pipe in table fence
  + L47: Add missing final pipe in table fence
  + L48: Add missing final pipe in table fence
  + L49: Add missing final pipe in table fence
  + L50: Add missing final pipe in table fence
  + L51: Add missing final pipe in table fence
  + L52: Add missing final pipe in table fence
  + L53: Add missing final pipe in table fence
  + L54: Add missing final pipe in table fence
  + L55: Add missing final pipe in table fence

PR-URL: #14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit that referenced this pull request Aug 13, 2017
@watilde @addaleax
doc: fix docs style in util.md
20fb690 
Summary
  + L582: Cell should be padded
  + L589: Cell should be padded
  + L590: Cell should be padded
  + L600: Cell should be padded
  + L622: Cell should be padded

PR-URL: #14711
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@addaleax addaleax mentioned this pull request Aug 13, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@watilde @refack @MylesBorins @jasnell @gibfahn @nodejs-github-bot