Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: ignore .DS_Store for macOS #14779

Closed
wants to merge 1 commit into from
Closed

gitignore: ignore .DS_Store for macOS #14779

wants to merge 1 commit into from

Conversation

tommyZZM
Copy link

fix some .DS_Store not ignoreing in macOS

#14721 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

.gitignore

@tommyZZM
gitignore: ignore .DS_Store for macOS
5ed2adb 
fix some .DS_Store not ignoreing in macOS

#14721 (comment)
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 12, 2017
Trott
Trott requested changes Aug 12, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides all the preceding rules. Previously, adding .foo to the test/fixtures directory would be reported by git, which is what we want. With this change, it will be ignored.

@tommyZZM tommyZZM closed this Aug 12, 2017
@Trott Trott mentioned this pull request Oct 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott requested changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommyZZM @Trott @nodejs-github-bot