debugger: introduce exec method for debugger #1491

JacksonTian · 2015-04-21T16:49:15Z

In debugger, the usage of repl very ugly. I'd like there is a p
like gdb. So the exec is coming.

Usage:

$ ./iojs debug ~/git/node_research/server.js
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in /Users/jacksontian/git/node_research/server.js:1
> 1 var http = require('http');
  2
  3 http.createServer(function (req, res) {
debug> exec('process.title')
/Users/jacksontian/git/io.js/out/Release/iojs
debug>

And the repl:

debug> repl
Press Ctrl + C to leave debug repl
> process.title
'/Users/jacksontian/git/io.js/out/Release/iojs'
debug>
(^C again to quit)

The enter and leave debug repl is superfluous.

bnoordhuis · 2015-04-21T16:59:30Z

lib/_debugger.js

@@ -1575,6 +1575,17 @@ Interface.prototype.repl = function() {
  this.repl.displayPrompt();
 };

+Interface.prototype.exec = function(code) {
+  var self = this;
+  this.debugEval(code, null, null, function (err, result) {


Minor style issue: no space after function keyword.

bnoordhuis · 2015-04-21T16:59:42Z

LGTM sans style nit.

JacksonTian · 2015-04-22T02:46:12Z

thanks @bnoordhuis

chrisdickinson · 2015-04-22T19:30:01Z

Curious: down the line is there interest in moving to a more python pdb-style debugger, where the interface is a REPL by default and will evaluate any expression inline, but still respond to debugging commands?

monsanto · 2015-04-22T20:18:47Z

@chrisdickinson +1 this tripped me up when I first started playing with Node

JacksonTian · 2015-04-24T14:31:39Z

@chrisdickinson hope there is an idb or ndb command.

JacksonTian · 2015-05-04T14:05:09Z

ping anyone?

silverwind · 2015-05-10T10:50:11Z

Not sure this is the best approach. exec('') seems a bit too verbose.

I've recently experimented with the debugger for the first time, and was a bit surprised it wasn't a real repl. How about actually making it a repl and adding all debug related commands to the existing list of commands shown in the repl with .help?

This would of course be an incompatible change, but having all commands prefixed with a dot would be my preferred method. Maybe add a short print to refer to .help on debug start.

rlidwka · 2015-05-10T13:01:15Z

This would of course be an incompatible change, but having all commands prefixed with a dot would be my preferred method.

I use debugger heavily, and most commands I use are n, s and c. So I don't really like the idea to prefix them with dots: that's twice the amount of characters to type.

JacksonTian · 2015-05-10T14:49:21Z

@silverwind the exec(exp) is a shorthand of repl + exp + control/c, and not an incompatible change.

chrisdickinson · 2015-05-10T21:27:57Z

I think we should take a page from python's book and allow those commands unprefixed, but if the line isn't a known command treat it as a repl utterance.

On May 10, 2015, at 6:01 AM, Alex Kocharin notifications@github.com wrote:

This would of course be an incompatible change, but having all commands prefixed with a dot would be my preferred method.

I use debugger heavily, and most commands I use are n, s and c. So I don't really like the idea to prefix them with dots: that's twice the amount of characters to type.

—
Reply to this email directly or view it on GitHub.

rlidwka · 2015-05-11T01:05:18Z

I think we should take a page from python's book

That one where n+1 means next, but 1+n means local variable access?

>>> import pdb
>>> pdb.run('for n in range(1, 100):\n  n')
> <string>(1)<module>()
(Pdb) n
> <string>(2)<module>()
(Pdb) print n
1
(Pdb) n+1
> <string>(1)<module>()
(Pdb) 1+n
2

silverwind · 2015-05-11T14:37:01Z

One way around this variable name problem could be to require a semicolon to access local variables, so n; would get you the variable, n would execute next.

jasnell · 2015-10-22T02:28:19Z

@nodejs/collaborators ... anyone have any idea on the status of this? Is it still something that's wanted? /cc @JacksonTian

JacksonTian · 2015-10-22T04:52:31Z

yes, repl is ugly.

silverwind · 2015-10-22T05:10:41Z

@JacksonTian can you at least make it exec process.title or short e process.title?

JacksonTian · 2015-10-22T06:02:31Z

ok.

JacksonTian · 2015-10-22T07:44:49Z

@silverwind Implement exec process.title is ok. I'd like to know whether the command expr style fit the API style, the other command meet command() function call style.

silverwind · 2015-10-22T10:27:49Z

test/debugger/test-debugger-repl.js

  /\d/, /\d/, /\d/, /\d/, /\d/
 ]);

+// Execute
+addTest('exec("process.title")', [
+  /iojs/


needs to be node now ;)

bnoordhuis · 2015-11-17T12:52:03Z

lib/_debugger.js

@@ -949,6 +950,12 @@ Interface.prototype.controlEval = function(code, context, filename, callback) {
      }
    }

+    // exec process.title => exec("process.title");
+    var match = code.match(/exec\s+([^\n]*)/);


This should probably use an anchoring match (i.e. /^\s*exec) so it won't get confused by e.g. "exec exec exec" as the input.

EDIT: Can you add a regression test for that while you're at it? Thanks.

JacksonTian · 2015-11-17T14:21:52Z

Thanks @bnoordhuis , I updated the commit.

cjihrig · 2015-11-17T16:18:03Z

lib/_debugger.js

+// execute expression
+Interface.prototype.exec = function(code) {
+  var self = this;
+  this.debugEval(code, null, null, function(err, result) {


Could you use an arrow function callback and get rid of self.

The PR was submitted long time ago : ). updated.

In debugger, the usage of `repl` very ugly. I'd like there is a `p` like gdb. So the `exec` is coming. Usage: ``` $ ./iojs debug ~/git/node_research/server.js < Debugger listening on port 5858 connecting to 127.0.0.1:5858 ... ok break in /Users/jacksontian/git/node_research/server.js:1 > 1 var http = require('http'); 2 3 http.createServer(function (req, res) { debug> exec process.title /Users/jacksontian/git/io.js/out/Release/iojs debug> ``` And the `repl`: ``` debug> repl Press Ctrl + C to leave debug repl > process.title '/Users/jacksontian/git/io.js/out/Release/iojs' debug> (^C again to quit) ``` The enter and leave debug repl is superfluous.

cjihrig · 2015-11-17T16:27:06Z

Thanks, LGTM.

bnoordhuis · 2015-11-17T18:11:01Z

LGTM2. I can't start the CI though, seems to be down at the moment.

bnoordhuis · 2015-11-17T18:13:15Z

And it's up again: https://ci.nodejs.org/job/node-test-pull-request/767/

In debugger, the usage of `repl` very ugly. I'd like there is a `p` like gdb. So the `exec` is coming. Usage: ``` $ ./iojs debug ~/git/node_research/server.js < Debugger listening on port 5858 connecting to 127.0.0.1:5858 ... ok break in /Users/jacksontian/git/node_research/server.js:1 > 1 var http = require('http'); 2 3 http.createServer(function (req, res) { debug> exec process.title /Users/jacksontian/git/io.js/out/Release/iojs debug> ``` And the `repl`: ``` debug> repl Press Ctrl + C to leave debug repl > process.title '/Users/jacksontian/git/io.js/out/Release/iojs' debug> (^C again to quit) ``` The enter and leave debug repl is superfluous. R-URL: #1491 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell · 2015-11-17T20:14:53Z

Failures in CI look unrelated. Will get this landed.

jasnell · 2015-11-17T20:15:01Z

Landed in b33e9da

In debugger, the usage of `repl` very ugly. I'd like there is a `p` like gdb. So the `exec` is coming. Usage: ``` $ ./iojs debug ~/git/node_research/server.js < Debugger listening on port 5858 connecting to 127.0.0.1:5858 ... ok break in /Users/jacksontian/git/node_research/server.js:1 > 1 var http = require('http'); 2 3 http.createServer(function (req, res) { debug> exec process.title /Users/jacksontian/git/io.js/out/Release/iojs debug> ``` And the `repl`: ``` debug> repl Press Ctrl + C to leave debug repl > process.title '/Users/jacksontian/git/io.js/out/Release/iojs' debug> (^C again to quit) ``` The enter and leave debug repl is superfluous. R-URL: #1491 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins · 2016-03-10T20:52:30Z

Is this something we would want in LTS? /cc @nodejs/lts

jasnell · 2016-03-11T00:41:43Z

hmmm... good question. lts-agenda label applied.

MylesBorins · 2016-03-21T21:01:35Z

lts wg has agreed this poses little risk. Added lts-watch label and we can add this to the next LTS semver minor bump

In debugger, the usage of `repl` very ugly. I'd like there is a `p` like gdb. So the `exec` is coming. Usage: ``` $ ./iojs debug ~/git/node_research/server.js < Debugger listening on port 5858 connecting to 127.0.0.1:5858 ... ok break in /Users/jacksontian/git/node_research/server.js:1 > 1 var http = require('http'); 2 3 http.createServer(function (req, res) { debug> exec process.title /Users/jacksontian/git/io.js/out/Release/iojs debug> ``` And the `repl`: ``` debug> repl Press Ctrl + C to leave debug repl > process.title '/Users/jacksontian/git/io.js/out/Release/iojs' debug> (^C again to quit) ``` The enter and leave debug repl is superfluous. R-URL: #1491 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

JacksonTian force-pushed the introduce_exec branch from 442a8bf to 5d32f5d Compare April 21, 2015 16:50

JacksonTian changed the title ~~Introduce exec~~ debugger: introduce exec method for debugger Apr 21, 2015

bnoordhuis reviewed Apr 21, 2015
View reviewed changes

mscdex added the debugger label Apr 21, 2015

JacksonTian force-pushed the introduce_exec branch 3 times, most recently from 39fa227 to a358dee Compare April 22, 2015 04:16

silverwind added the semver-minor PRs that contain new features and should be released in the next minor version. label May 14, 2015

bnoordhuis force-pushed the master branch from 311c3e4 to b926718 Compare June 2, 2015 17:25

rvagg force-pushed the master branch from 9d21135 to 628a3ab Compare June 25, 2015 09:18

indutny force-pushed the master branch from bffb204 to eb35968 Compare July 22, 2015 21:21

rvagg force-pushed the master branch from 11c25c2 to ba02bd0 Compare September 6, 2015 11:55

silverwind reviewed Oct 22, 2015
View reviewed changes

bnoordhuis reviewed Nov 17, 2015
View reviewed changes

JacksonTian force-pushed the introduce_exec branch from 5cdde8e to 1031ab0 Compare November 17, 2015 14:20

cjihrig reviewed Nov 17, 2015
View reviewed changes

JacksonTian force-pushed the introduce_exec branch from 1031ab0 to dbeac9a Compare November 17, 2015 16:20

jasnell closed this Nov 17, 2015

jasnell added the lts-agenda label Mar 11, 2016

MylesBorins mentioned this pull request Mar 21, 2016

LTS Meeting - 2016-03-21 nodejs/Release#89

Closed

MylesBorins added lts-watch-v4.x and removed lts-agenda labels Mar 21, 2016

MylesBorins mentioned this pull request May 16, 2016

Release Schedule for v4.4.5 and v4.5.0 nodejs/Release#102

Closed

MylesBorins self-assigned this May 17, 2016

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels May 27, 2016

MylesBorins removed their assignment Dec 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

debugger: introduce exec method for debugger #1491

debugger: introduce exec method for debugger #1491

JacksonTian commented Apr 21, 2015

bnoordhuis Apr 21, 2015

bnoordhuis commented Apr 21, 2015

JacksonTian commented Apr 22, 2015

chrisdickinson commented Apr 22, 2015

monsanto commented Apr 22, 2015

JacksonTian commented Apr 24, 2015

JacksonTian commented May 4, 2015

silverwind commented May 10, 2015

rlidwka commented May 10, 2015

JacksonTian commented May 10, 2015

chrisdickinson commented May 10, 2015

rlidwka commented May 11, 2015

silverwind commented May 11, 2015

jasnell commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

silverwind commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

silverwind Oct 22, 2015

bnoordhuis Nov 17, 2015

JacksonTian commented Nov 17, 2015

cjihrig Nov 17, 2015

JacksonTian Nov 17, 2015

cjihrig commented Nov 17, 2015

bnoordhuis commented Nov 17, 2015

bnoordhuis commented Nov 17, 2015

jasnell commented Nov 17, 2015

jasnell commented Nov 17, 2015

MylesBorins commented Mar 10, 2016

jasnell commented Mar 11, 2016

MylesBorins commented Mar 21, 2016

debugger: introduce exec method for debugger #1491

debugger: introduce exec method for debugger #1491

Conversation

JacksonTian commented Apr 21, 2015

bnoordhuis Apr 21, 2015

Choose a reason for hiding this comment

bnoordhuis commented Apr 21, 2015

JacksonTian commented Apr 22, 2015

chrisdickinson commented Apr 22, 2015

monsanto commented Apr 22, 2015

JacksonTian commented Apr 24, 2015

JacksonTian commented May 4, 2015

silverwind commented May 10, 2015

rlidwka commented May 10, 2015

JacksonTian commented May 10, 2015

chrisdickinson commented May 10, 2015

rlidwka commented May 11, 2015

silverwind commented May 11, 2015

jasnell commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

silverwind commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

JacksonTian commented Oct 22, 2015

silverwind Oct 22, 2015

Choose a reason for hiding this comment

bnoordhuis Nov 17, 2015

Choose a reason for hiding this comment

JacksonTian commented Nov 17, 2015

cjihrig Nov 17, 2015

Choose a reason for hiding this comment

JacksonTian Nov 17, 2015

Choose a reason for hiding this comment

cjihrig commented Nov 17, 2015

bnoordhuis commented Nov 17, 2015

bnoordhuis commented Nov 17, 2015

jasnell commented Nov 17, 2015

jasnell commented Nov 17, 2015

MylesBorins commented Mar 10, 2016

jasnell commented Mar 11, 2016

MylesBorins commented Mar 21, 2016