Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: --enable-static linked executable #14986

Closed
wants to merge 7 commits into from

Commits on Nov 13, 2017

  1. Configuration menu
    Copy the full SHA
    83027c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2017

  1. test: --enable-static linked executable

    The motivation for this commit is to enable projects embedding Node.js
    and building with --enable-static to be able to run the test suite and
    linter.
    
    Currently when building with --enable-static no node executable
    will be created which means that the tests (apart from the cctest) and
    linter cannot be run.
    
    This is currently a work in progress and works on MacOS but I need to
    run the CI, and manually on different environments to verify that it
    works as expected.
    danbev committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    8bf2bea View commit details
    Browse the repository at this point in the history
  2. Revert "build: for --enable-static, run only cctest"

    This reverts commit a36b540.
    danbev committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    163f0e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acb0b8b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4692561 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8f23991 View commit details
    Browse the repository at this point in the history
  6. squash: remove whole-archive for aix

    This commit excludes aix from using whole-archive which does not seem to
    be supported. Reading the documentation for ld
    (https://www.ibm.com/support/knowledgecenter/ssw_aix_61/
    com.ibm.aix.cmds3/ld.htm) I found this:
    "The first definition of a symbol is kept, even if no reference to the
    symbol has been seen when the archive is read. In other versions of
    the ld command, a symbol defined in an archive is ignored if no
    reference to the symbol has been seen when the archive is read."
    
    This sounds like it will not ignore a symbol just because it is not used
    similar to when the whole-archive flag is used. Going to try this and
    see if it works.
    danbev committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    0b63276 View commit details
    Browse the repository at this point in the history