Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #15181

Closed
wants to merge 1 commit into from
Closed

doc: update AUTHORS list #15181

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 4, 2017

Update AUTHORS list using tools/update-authors.sh.

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 4, 2017
@targos
Copy link
Member Author

targos commented Sep 4, 2017

There may be a few duplicates but this adds 282 new collaborators since the last update that was 4 months ago 🎉

AUTHORS Outdated
liusi <siyuan.liu@autodesk.com>
Noj Vek <noj.vek@mixpanel.com>
Ruslan Bekenev <furyinbox@gmail.com>
Danny Nemer <hi@DannyNemer.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

AUTHORS Outdated
Chris Burkhart <christide@christide.com>
Rj Bernaldo <rj.bernaldo@gmail.com>
John F. Mercer <john.f.mercer@gmail.com>
Pedro lima <pvsousalima@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

AUTHORS Outdated
Griffith Tchenpan <griffith.tchenpan@myworkpapers.com>
Oky Antoro <kiantrue@gmail.com>
icarter09 <icarter1391@gmail.com>
Saad Quadri <saad@saadq.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

AUTHORS Outdated
Artur Vieira <vieira.artur.g@gmail.com>
Flarna <deb2001-github@yahoo.de>
kysnm <tokyoincidents.g@gmail.com>
Artur G Vieira <vieira.artur.g@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dup of 1504.

AUTHORS Outdated
Madara Uchiha <me@madara.ninja>
Gil Tayar <gil@tayar.org>
Glenn Schlereth <Glenn.Schlereth@gmail.com>
Michael Dawson <mdawson@devrus.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a dupe? @mhdawson can you confirm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a dupe

AUTHORS Outdated
Artur G Vieira <vieira.artur.g@gmail.com>
Sreepurna Jasti <jsreepur@in.ibm.com>
Rafael Fragoso <rafaelfragosom@gmail.com>
daniel.bevenius <daniel.bevenius@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe.

AUTHORS Outdated
Ankit Parashar <ankitabc12@gmail.com>
James Kyle <me@thejameskyle.com>
Daniil Shakir <phpinfo12345@gmail.com>
davidmarkclements <huperekchuno@googlemail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe.

AUTHORS Outdated
Christian d'Heureuse <chdh@inventec.ch>
Shahar Or <mightyiampresence@gmail.com>
detailyang <detailyang@gmail.com>
jBarz <jbarboza@ca.ibm.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe.

AUTHORS Outdated
Uppinder Chugh <uppinderchugh@gmail.com>
Karl Cheng <qantas94heavy@gmail.com>
Taylor Woll <taylor.woll@microsoft.com>
taylor.woll <tawoll@ntdev.microsoft.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe of the line above.

AUTHORS Outdated
Paul Bininda <paul@bininda.com>
sreepurnajasti <sreepurna.jasti@gmail.com>
Gautam Mittal <200mittalgautam@gmail.com>
Jamen Marz <jamenmarz+gh@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe of 1543

AUTHORS Outdated
Mandeep Singh <mandeep.singh@zomato.com>
Prakash Palaniappan <prakaash.kpk@gmail.com>
Keita Akutsu <kakts.git@gmail.com>
Gareth Ellis <gareth@gsellis.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dupe. Different email address though.

Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with those fixed.

Steven Lehn <sjlehn@gmail.com>
Łukasz Szewczak <lukaszewczak@gmail.com>
Madara Uchiha <me@madara.ninja>
Gil Tayar <gil@tayar.org>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUTHORS Outdated
Rob Wu <rob@robwu.nl>
Steven Winston <swinston100@hotmail.com>
sallen450 <jqh101@sina.com>
OriLev <sviatos@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AUTHORS Outdated
Zhang Weijie <email@zhangweijie.cn>
Gunar C. Gessner <gunar@gunargessner.com>
SkyAo <csvwolf@qq.com>
Benjamin Gruenbaum <benji@peer5.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely a duplicate of inglor@gmail.com (work mail vs. old personal mail)

@silverwind
Copy link
Contributor

Instead of removing duplicates, you should use .mailmap to alias them instead. That way, the next time this file is regenerated, you don't have to dedupe the same users again.

@LakshmiSwethaG
Copy link
Contributor

@targos, thanks for this. I have since then changed my organization, and therefore the email IDs too. Can you please replace lgopired@in.ibm.com with lakshmiswethagopireddy@gmail.com?
thanks in advance."

@targos
Copy link
Member Author

targos commented Sep 5, 2017

@silverwind do you know how it works? Because for example Ben keeps being added even though all his addresses are in the .mailmap

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silverwind
Copy link
Contributor

silverwind commented Sep 5, 2017

@targos I'm pretty sure that Ben's entry in .mailmap is invalid:

Ben Noordhuis <info@bnoordhuis.nl> <bnoordhuis@bender.(none)> <ben@strongloop.com>

Acorrding to the shortlog docs, a mailmap entry can either contain a mail address or a mail address and a name after the "proper name and address", and certainly not three adresses so corrected, it should be:

Ben Noordhuis <info@bnoordhuis.nl> <bnoordhuis@bender.(none)>
Ben Noordhuis <info@bnoordhuis.nl> <ben@strongloop.com>

From a quick look, I think this is the only error in the current .mailmap.

@targos
Copy link
Member Author

targos commented Sep 5, 2017

@silverwind Thank you, I understand now. Updating...

@bidipyne
Copy link
Contributor

bidipyne commented Sep 5, 2017

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs bidipyne@in.ibm.com to pyne.bidisha2017@gmail.com?
Thank You!

@200GAUTAM
Copy link
Contributor

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs gaumit34@in.ibm.com to 200mittalgautam@gmail.com?
Thank You!

AUTHORS Outdated
Artur Vieira <vieira.artur.g@gmail.com>
Flarna <deb2001-github@yahoo.de>
kysnm <tokyoincidents.g@gmail.com>
Sreepurna Jasti <jsreepur@in.ibm.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos As I have changed my organization, I would request you to update this with my personal email id: sreepurna.jasti@gmail.com. Thanks in advance.

AUTHORS Outdated
Alexander O'Mara <me@alexomara.com>
James, please <jamesplease2@gmail.com>
Josh Ferge <josh@augur.io>
sreepurnajasti <jsreepur@in.ibm.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@targos As I have changed my organization, I would request you to update this with my personal email id: sreepurna.jasti@gmail.com.

Thanks in advance.

Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member Author

targos commented Sep 6, 2017

@LakshmiSwethaG, @bidipyne, @sreepurnajasti I changed your emails in the map.
@200GAUTAM I think it's already fine for you?

@targos
Copy link
Member Author

targos commented Sep 6, 2017

@lpinca @TimothyGu @XadillaX @mhdawson @silverwind I made a significant change since last review. Now the mailmap is up to date and running tools/update-authors.sh creates the AUTHORS file as it is in my branch.

.mailmap Outdated
Onne Gorter <onne@onnlucky.com>
Paul Querna <pquerna@apache.org> <paul@querna.org>
Pedro Lima <pvsousalima@gmail.com> Pedro Victor <pvsousalima@gmail.com>
Pedro Lima <pvsousalima@gmail.com> Pedro Lima <pvsousalima@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, but I made a typo. It's a version of the name with lowercase "L". Weird that it was working with that mistake...

Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailmap is 🥇

@200GAUTAM
Copy link
Contributor

@targos yes 200mittalgautam@gmail.com was already there , Sorry for the confusion

@targos
Copy link
Member Author

targos commented Sep 6, 2017

I searched for all remaining duplicate email addresses in AUTHORS and added them to the map

@@ -1102,16 +1102,14 @@ Michael-Rainabba Richardson <rainabba@gmail.com>
oogz <oogz@users.noreply.github.com>
Rene Weber <weber.rene@live.de>
Lauren Spiegel <lhspiegel@gmail.com>
Lydia Katsamberis <llkats@gmail.com>
Lydia Kats <llkats@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the first one is a more formal name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose the one that is on their GitHub profile: https://github.com/llkats

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach LGTM

Update AUTHORS list using tools/update-authors.sh.
@targos
Copy link
Member Author

targos commented Sep 12, 2017

Landed in 3f7813b

@targos targos closed this Sep 12, 2017
@targos targos deleted the update-authors branch September 12, 2017 08:13
targos added a commit that referenced this pull request Sep 12, 2017
Update AUTHORS list using tools/update-authors.sh.
Update .mailmap to handle duplicates.

PR-URL: #15181
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
Update AUTHORS list using tools/update-authors.sh.
Update .mailmap to handle duplicates.

PR-URL: nodejs#15181
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
Update AUTHORS list using tools/update-authors.sh.
Update .mailmap to handle duplicates.

PR-URL: #15181
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
Update AUTHORS list using tools/update-authors.sh.
Update .mailmap to handle duplicates.

PR-URL: #15181
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 17, 2017
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
Update AUTHORS list using tools/update-authors.sh.
Update .mailmap to handle duplicates.

PR-URL: #15181
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.