Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: kill subprocess only after last ACK #15186

Merged
merged 1 commit into from
Sep 11, 2017
Merged

test: kill subprocess only after last ACK #15186

merged 1 commit into from
Sep 11, 2017

Conversation

refack
Copy link
Contributor

@refack refack commented Sep 4, 2017

  • Add multiple comments.
  • Switch to a persistent fixture for subprocess.
  • Assert that send queue is drained.

Fixes: #15176

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test, child_process

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 4, 2017
@refack refack added child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Sep 4, 2017
@refack
Copy link
Contributor Author

refack commented Sep 4, 2017 •
edited
Loading

Failing Stress: https://ci.nodejs.org/job/node-stress-single-test/1402/nodes=win-vs2015/ 🔴
PR stress CI: https://ci.nodejs.org/job/node-stress-single-test/1403/nodes=win-vs2015/ ✔️

jasnell
jasnell approved these changes Sep 7, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@refack
Copy link
Contributor Author

refack commented Sep 11, 2017

CI https://ci.nodejs.org/job/node-test-commit/12259/ literally Green

@refack
test: kill subprocess only after last ACK
94be2b1 
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: nodejs#15186
Fixes: nodejs#15176
Reviewed-By: James M Snell <jasnell@gmail.com>
@refack refack force-pushed the deflake-parallel-test-child-process-send-returns-boolean branch from 1e005d5 to 94be2b1 Compare September 11, 2017 00:24
@refack refack merged commit 94be2b1 into nodejs:master Sep 11, 2017
@refack refack deleted the deflake-parallel-test-child-process-send-returns-boolean branch September 11, 2017 00:27
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@addaleax
test: kill subprocess only after last ACK
b5430b4 
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: nodejs#15186
Fixes: nodejs#15176
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@refack @jasnell
test: kill subprocess only after last ACK
f0a741d 
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: #15186
Fixes: #15176
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Sep 20, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: investigate flaky test-child-process-send-returns-boolean
4 participants
@refack @MylesBorins @jasnell @nodejs-github-bot