http2: improve http2 coverage #15210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve http2 coverage through refactoring and tests
nodejs-github-bot
added
c++
|
CI https://ci.nodejs.org/job/node-test-pull-request/10015/ [I posted the wrong one first] |
|
Would be nice to see this get reviewed & merged. |
|
This does not land cleanly, it needs a rebase. |
jasnell
added a commit
that referenced
this pull request
Sep 13, 2017
Improve http2 coverage through refactoring and tests PR-URL: #15210 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
It just needed a |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
Improve http2 coverage through refactoring and tests PR-URL: nodejs/node#15210 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
added a commit
that referenced
this pull request
Sep 20, 2017
Improve http2 coverage through refactoring and tests PR-URL: #15210 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Improve http2 coverage through refactoring and tests PR-URL: nodejs/node#15210 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve http2 coverage through refactoring and tests
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2, test