Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: stop creating references to primitives #15289

Closed
wants to merge 1 commit into from
Closed

n-api: stop creating references to primitives #15289

wants to merge 1 commit into from

Commits on Sep 9, 2017

  1. n-api: stop creating references to primitives 

    The binding testing napi_wrap() creates references to primitives passed
into the binding in its second parameter. This is unnecessary and not
at all the point of the test. Additionally, creating persistent
references to primitive values may not be supported by all VMs, since
primitives are best persisted in their native form.

Instead, the point of the test is to make sure that the finalize
callback gets called when it should get called, that it gets called
with the correct pointer, and that it does not get called when it
should not get called. Creating persistent references is not necessary
for verifying this.

Re: nodejs/node-chakracore#380
    Gabriel Schulhof committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    2b78ff9 View commit details
    Browse the repository at this point in the history