test: expand http2 maxSendHeaderBlockLength test case #15298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 12, 2017
BridgeAR
reviewed
Sep 13, 2017
| })(err); | ||
| req2.on('error', common.expectsError({ | ||
| code: 'ERR_HTTP2_STREAM_ERROR', | ||
| message: 'Stream closed with error code 7' |
There was a problem hiding this comment.
It is always a good idea to add the type as well.
|
@apapirovski ... can you address @BridgeAR's comment? Then I'll get this landed. |
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available.
apapirovski
force-pushed
the
patch-http2-framerror-handling
branch
from
6f529c8 to
ac192b1
Compare
|
Failures in |
BridgeAR
approved these changes
Sep 19, 2017
|
@apapirovski they are definitely unrelated. I think that test is already fixed / there is a open PR to fix that one. |
refack
approved these changes
Sep 19, 2017
|
Landed in 15879ad |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 20, 2017
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available. PR-URL: #15298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available. PR-URL: #15298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available. PR-URL: nodejs/node#15298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
Expand maxSendHeaderBlockLength test to check what happens if frameError listener isn't available. PR-URL: nodejs/node#15298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny change to expand
maxSendHeaderBlockLengthtest to check what happens ifframeErrorlistener isn't available.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test