[v6.x backport] doc: add documentation on ICU #15353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyGu
added
doc
doc/api/intl.md
Outdated
| console.log(english.format(january)); | ||
| // Prints "January" | ||
| console.log(spanish.format(january)); | ||
| // Prints "January" on small-icu |
There was a problem hiding this comment.
Default v6.11.3 prints M01 for me (Windows 7 x64).
There was a problem hiding this comment.
Hmm, it's M01 for me on master as well but January on v6.x. Can you check the output after changing your LC_ALL environment variable to en_US?
There was a problem hiding this comment.
Output:
> set LC_ALL=en_US
> set LC_ALL
LC_ALL=en_US
> node.6.11.3.v8-5.1.exe
> const january = new Date(9e8);
> const english = new Intl.DateTimeFormat('en', { month: 'long' });
> const spanish = new Intl.DateTimeFormat('es', { month: 'long' });
> console.log(english.format(january));
January
> // Prints "January"
> console.log(spanish.format(january));
M01
> // Prints "January" on small-icu
> // Should print "enero"There was a problem hiding this comment.
FWIW, I use the standalone binary from https://nodejs.org/download/release/latest-v6.x/win-x64/
There was a problem hiding this comment.
Ah you are on Windows. That's different...
There was a problem hiding this comment.
So maybe we can state "January" or "M01"?
There was a problem hiding this comment.
@vsemozhetbyt Sounds like a good idea.
vsemozhetbyt
approved these changes
Sep 12, 2017
PR-URL: nodejs#13916 Refs: nodejs#13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
TimothyGu
force-pushed
the
v6.x-13916
branch
from
abbf810 to
d7293be
Compare
|
@vsemozhetbyt Done, PTAL! |
vsemozhetbyt
approved these changes
Sep 15, 2017
jasnell
approved these changes
Sep 15, 2017
|
landed in 90fcccd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Checklist
Affected core subsystem(s)
doc