doc: fix entryTypes type and missing link in perf_hooks.md #15406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Sep 14, 2017
lpinca
reviewed
Sep 14, 2017
doc/api/perf_hooks.md
Outdated
| @@ -656,3 +656,4 @@ require('some-module'); | |||
|
|
|||
| [`timeOrigin`]: https://w3c.github.io/hr-time/#dom-performance-timeorigin | |||
| [W3C Performance Timeline]: https://w3c.github.io/performance-timeline/ | |||
| [Async Hooks]: async_hooks.html | |||
There was a problem hiding this comment.
Can you please swap this with the previous line to keep them sorted alphabetically?
There was a problem hiding this comment.
Absolutely. Just to make sure, you mean
case 1:
a. timeOrigin
b. Async Hooks
c. W3C Performance Timeline
or case 2
a. Async Hooks
b. timeOrigin
c. W3C Performance Timeline
?
There was a problem hiding this comment.
@manidlou, case 1. Thanks.
lpinca
approved these changes
Sep 14, 2017
cjihrig
approved these changes
Sep 14, 2017
Done. |
daxlab
approved these changes
Sep 16, 2017
BridgeAR
approved these changes
Sep 19, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Sep 19, 2017
PR-URL: nodejs#15406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
PR-URL: #15406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#15406 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
entryTypesinperformance.timerify(fn)example andasync_hooksmissing link inperf_hooks.md.Checklist
Affected core subsystem(s)
doc