Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: expand http2 util test coverage for headers #15493

Closed
wants to merge 1 commit into from
Closed

test: expand http2 util test coverage for headers #15493

wants to merge 1 commit into from

Conversation

apapirovski
Copy link
Member

@apapirovski apapirovski commented Sep 20, 2017 •
edited
Loading

This PR expands existing test cases to hit some additional branches of toHeaderObject and mapToHeaders.

Thanks in advance for the reviews & any feedback!

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@apapirovski
test: expand http2 util test coverage for headers
ece20c9 
Expand existing test cases to hit some additional branches of
toHeaderObject and mapToHeaders.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 20, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Sep 20, 2017
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/10237/

@BridgeAR
Copy link
Member

Landed in d8a2266

@BridgeAR BridgeAR closed this Sep 24, 2017
BridgeAR pushed a commit that referenced this pull request Sep 24, 2017
@apapirovski @BridgeAR
test: expand http2 util test coverage for headers
d8a2266 
Expand existing test cases to hit some additional branches of
toHeaderObject and mapToHeaders.

PR-URL: #15493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@apapirovski apapirovski deleted the patch-http2-test-util branch September 24, 2017 18:13
jasnell pushed a commit that referenced this pull request Sep 25, 2017
@apapirovski @jasnell
test: expand http2 util test coverage for headers
409576e 
Expand existing test cases to hit some additional branches of
toHeaderObject and mapToHeaders.

PR-URL: #15493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@apapirovski @addaleax
test: expand http2 util test coverage for headers
0a60621 
Expand existing test cases to hit some additional branches of
toHeaderObject and mapToHeaders.

PR-URL: nodejs/node#15493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@snyk-bot snyk-bot mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@apapirovski @BridgeAR @jasnell @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot