Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assert.throws in test-http-invalid-urls #15678

Closed
wants to merge 1 commit into from

Commits on Sep 29, 2017

  1. test: fix and refactor test-http-invalid-urls

    When the second argument to `assert.throws()` is a string, it is not
    treated as the expected error message but rather the message that the
    assertion should display if no error is thrown. Ths change fixes that
    error in `test-http-invalid-urls.js`.
    
    Instead of skipping the test when there is no crypto, the test is now
    run but with `http` only. `https` is skipped.
    
    Logging was fixed. Previously, errors would be written out as being in
    the `[object Object]` module rather than `http` or `https`.
    Trott committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    a263630 View commit details
    Browse the repository at this point in the history