Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 client destroy tests in one file #15749

Closed
wants to merge 1 commit into from
Closed

test: http2 client destroy tests in one file #15749

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 3, 2017 •
edited
Loading

This PR includes all client destroy tests in one file.
It also rearranges some statements and removes redundant ones in destroy()

Refs: #14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 3, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 3, 2017
@trivikr trivikr force-pushed the test-http2-client-destroy branch from 7fb7aef to 5978e53 Compare October 3, 2017 05:42
jasnell
jasnell approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@benjamingr
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10414

mcollina
mcollina approved these changes Oct 7, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Oct 7, 2017

Landed as d6031bc

@mcollina mcollina closed this Oct 7, 2017
mcollina pushed a commit that referenced this pull request Oct 7, 2017
@trivikr @mcollina
test: http2 client destroy tests in one file
d6031bc 
Refs: #14985
PR-URL: #15749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@trivikr trivikr deleted the test-http2-client-destroy branch October 7, 2017 18:35
@MylesBorins
Copy link
Contributor

This is not landing cleanly on 8.x, can you please backport?

trivikr added a commit to trivikr/node that referenced this pull request Oct 7, 2017
@trivikr
test: http2 client destroy tests in one file
901303c 
Refs: nodejs#14985
PR-URL: nodejs#15749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@trivikr trivikr mentioned this pull request Oct 7, 2017
Closed
@trivikr
Copy link
Member Author

trivikr commented Oct 7, 2017

@MylesBorins I've created backport PR at #16070
I followed instructions given in

node/doc/guides/backporting-to-release-lines.md

Line 1 in e517bc9

# How to Backport a Pull Request to a Release Line

MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
@trivikr @MylesBorins
test: http2 client destroy tests in one file
8ae4ae6 
Refs: #14985
Backport-PR-URL: #16070
PR-URL: #15749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins
Copy link
Contributor

land in 8ae4ae6

@MylesBorins MylesBorins mentioned this pull request Oct 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@trivikr @MylesBorins
test: http2 client destroy tests in one file
f39c792 
Refs: #14985
Backport-PR-URL: #16070
PR-URL: #15749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@trivikr @addaleax
test: http2 client destroy tests in one file
1d655aa 
Refs: #14985
PR-URL: nodejs/node#15749
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@trivikr @benjamingr @mcollina @MylesBorins @jasnell @lance @mscdex @nodejs-github-bot