Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: trace_event macro line continuation cleanup #15750

Closed
wants to merge 1 commit into from
Closed

src: trace_event macro line continuation cleanup #15750

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Oct 3, 2017

This commit makes the macro line continuations line up.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: trace_event macro line continuation cleanup
119110a 
This commit makes the macro line continuations line up.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Oct 3, 2017
@danbev
Copy link
Contributor Author

danbev commented Oct 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10391/

danbev added a commit to danbev/node that referenced this pull request Oct 5, 2017
@danbev
src: trace_event macro line continuation cleanup
212b12c 
This commit makes the macro line continuations line up.

PR-URL: nodejs#15750
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
Copy link
Contributor Author

danbev commented Oct 5, 2017

Landed in 212b12c

@danbev danbev closed this Oct 5, 2017
@danbev danbev deleted the trace_event_macro_cleanup branch October 5, 2017 07:17
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
@danbev @MylesBorins
src: trace_event macro line continuation cleanup
a66515d 
This commit makes the macro line continuations line up.

PR-URL: #15750
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@danbev @MylesBorins
src: trace_event macro line continuation cleanup
0004214 
This commit makes the macro line continuations line up.

PR-URL: #15750
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@danbev @addaleax
src: trace_event macro line continuation cleanup
307268b 
This commit makes the macro line continuations line up.

PR-URL: nodejs/node#15750
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @MylesBorins @jasnell @addaleax @lpinca @cjihrig @nodejs-github-bot