Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: http2 session operations after destroy #15758

Closed
wants to merge 1 commit into from
Closed

test: http2 session operations after destroy #15758

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 3, 2017

This PR adds checks for invalid session errors for session operations when they're called after session.destroy() in HTTP2

Refs #14985

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http2

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 3, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 3, 2017
@trivikr trivikr force-pushed the test-http2-server-destroy branch from 92210c1 to 0b978f5 Compare October 3, 2017 17:14
@trivikr trivikr force-pushed the test-http2-server-destroy branch from 0b978f5 to 579ce40 Compare October 9, 2017 00:55
@trivikr
Copy link
Member Author

trivikr commented Oct 9, 2017

Performed git rebase with upstream/master

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10678/

@Trott
Copy link
Member

Trott commented Oct 13, 2017

Ci will need to be re-run for this. It's not running any subtasks.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10704/

@trivikr trivikr force-pushed the test-http2-server-destroy branch from 579ce40 to 3a0df5f Compare October 14, 2017 21:51
@trivikr
Copy link
Member Author

trivikr commented Oct 14, 2017

The CI is failing on slower platforms https://ci.nodejs.org/job/node-test-commit/13125//console
I've updated commit passing common.platformTimeout() to setTimeout instead of number, as recommended in the documentation

@joyeecheung
Copy link
Member

new CI: https://ci.nodejs.org/job/node-test-pull-request/10720/

Trott
Trott previously requested changes Oct 15, 2017
View reviewed changes
test/parallel/test-http2-server-stream-session-destroy.js Outdated
common.expectsError(() => session.settings(), invalidSessionError);
common.expectsError(() => session.shutdown(), invalidSessionError);
common.expectsError(() => session.rstStream(), invalidSessionError);
}, common.platformTimeout(100), stream.session);
Copy link
Member

@Trott Trott Oct 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the other PR, please undo this setTimeout() and common.platformTimeout() change unless you can demonstrate a need. In general, please don't make changes to tests because of unrelated failures in CI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to setImmediate in the new commit

@Trott
Copy link
Member

Trott commented Oct 15, 2017 •
edited
Loading

It looks like this deletes a test file. Is that a mistake? If not, can you explain?

@trivikr trivikr force-pushed the test-http2-server-destroy branch from 3a0df5f to 23d4933 Compare October 15, 2017 03:26
@trivikr
Copy link
Member Author

trivikr commented Oct 15, 2017

@Trott The file test-http2-server-destroy-before-shutdown.js is purposely removed.
The file used to test shutdown call after destroy. It's now being tested in test-http2-server-stream-session-destroy.js on line 46 and 53

@Trott Trott dismissed their stale review October 15, 2017 03:41

common.platformTimeout() has been removed. Thanks!

@Trott
Copy link
Member

Trott commented Oct 15, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10725/

jasnell pushed a commit that referenced this pull request Oct 15, 2017
@trivikr @jasnell
test: http2 session operations after destroy
abbdcaa 
Refs #14985

PR-URL: #15758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@jasnell
Copy link
Member

jasnell commented Oct 15, 2017

Landed in abbdcaa

@jasnell jasnell closed this Oct 15, 2017
@trivikr trivikr deleted the test-http2-server-destroy branch October 15, 2017 22:32
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@trivikr @addaleax
test: http2 session operations after destroy
78963ee 
Refs #14985

PR-URL: nodejs/node#15758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@trivikr @MylesBorins
test: http2 session operations after destroy
c07d757 
Refs #14985

PR-URL: #15758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott left review comments

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@trivikr @joyeecheung @Trott @jasnell @JungMinu @mscdex @MylesBorins @nodejs-github-bot