Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js #15822

Closed
wants to merge 1 commit into from
Closed

test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js #15822

wants to merge 1 commit into from

Conversation

genewoo
Copy link
Contributor

@genewoo genewoo commented Oct 6, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]
Affected core subsystem(s)

N/A

@genewoo
test: fix fixturesDir in test-fs-symlink-dir-junction-relative.js
f74dba1 
common.fixturesDir -> common.fixtures.fixturesDir
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
rmg
rmg reviewed Oct 6, 2017
View reviewed changes
Copy link
Contributor

@rmg rmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

test/parallel/test-fs-symlink-dir-junction-relative.js
const assert = require('assert');
const path = require('path');
const fs = require('fs');

const linkPath1 = path.join(common.tmpDir, 'junction1');
const linkPath2 = path.join(common.tmpDir, 'junction2');
const linkTarget = path.join(common.fixturesDir);
const linkData = path.join(common.fixturesDir);
const linkTarget = path.join(fixtures.fixturesDir);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this could just be changed to const linkTarget = fixtures.fixuresDir;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmg maybe this could be handled when it lands? See nodejs/code-and-learn#70 (comment). I know this isn't really a nit such as message line lengths, but I agree with @gibfahn that force pushes and amended commits are a bit of a high barrier for code-and-learn first time contributors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force pushing isn't required for this, @genewoo if you would be willing to make the change @rmg suggested that would be great, you can change the line and push another commit to your branch.

Agreed that this isn't a blocker (which I assume is why @rmg didn't request changes).

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
lance
lance approved these changes Oct 7, 2017
View reviewed changes
test/parallel/test-fs-symlink-dir-junction-relative.js
const assert = require('assert');
const path = require('path');
const fs = require('fs');

const linkPath1 = path.join(common.tmpDir, 'junction1');
const linkPath2 = path.join(common.tmpDir, 'junction2');
const linkTarget = path.join(common.fixturesDir);
const linkData = path.join(common.fixturesDir);
const linkTarget = path.join(fixtures.fixturesDir);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmg maybe this could be handled when it lands? See nodejs/code-and-learn#70 (comment). I know this isn't really a nit such as message line lengths, but I agree with @gibfahn that force pushes and amended commits are a bit of a high barrier for code-and-learn first time contributors.

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10560/
[note when landing]: there is an outstanding code review comment that needs to be incorporated when landing, if author is not making the change.

@joyeecheung
Copy link
Member

Landed in 734ec0b with #15822 (comment) fixed. Thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 13, 2017
@genewoo @joyeecheung
test: use fixtures.fixturesDir
734ec0b 
PR-URL: #15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@genewoo @addaleax
test: use fixtures.fixturesDir
7495beb 
PR-URL: nodejs/node#15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@genewoo @targos
test: use fixtures.fixturesDir
b463259 
PR-URL: #15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@genewoo @MylesBorins
test: use fixtures.fixturesDir
9dac106 
PR-URL: #15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@genewoo @MylesBorins
test: use fixtures.fixturesDir
ee73883 
PR-URL: #15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@genewoo @MylesBorins
test: use fixtures.fixturesDir
a6f04be 
PR-URL: #15822
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmg rmg rmg left review comments

@gibfahn gibfahn gibfahn approved these changes

@lance lance lance approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@genewoo @gireeshpunathil @joyeecheung @lance @rmg @gibfahn @mscdex @MylesBorins @Trott @nodejs-github-bot