test: replace fixturesDir to use fixtures module #15831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelgolda
reviewed
Oct 6, 2017
test/parallel/test-fs-symlink.js
Outdated
| @@ -34,7 +35,7 @@ let fileTime; | |||
| common.refreshTmpDir(); | |||
|
|
|||
| // test creating and reading symbolic link | |||
| const linkData = path.join(common.fixturesDir, '/cycles/root.js'); | |||
| const linkData = path.join(fixtures.fixturesDir, '/cycles/root.js'); | |||
There was a problem hiding this comment.
This could be using method fixtures.path instead of path.join.
joshualim92
force-pushed
the
update-fixtures-test-fs-symlink
branch
from
bf1eacd to
9c89056
Compare
|
@pawelgolda good catch. I updated the PR. |
rmg
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
benjamingr
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
|
@gireeshpunathil I rebased again with the upstream master and all the tests are passing locally. Maybe the CI job will pass now? |
|
It seems like something went wrong while rebasing. There are lots of unrelated commits in here. |
joshualim92
force-pushed
the
update-fixtures-test-fs-symlink
branch
from
1b8f1a6 to
19f5b96
Compare
|
@BridgeAR, not sure how that happened. Should be fixed now. |
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15831 iReviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
|
Landed in e04e927 |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15831 iReviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15831 iReviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change usage of fixturesDir to be from the common.fixtures module instead of common.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test