Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir with common.fixtures module #15843

Closed
wants to merge 3 commits into from
Closed

test: replace common.fixturesDir with common.fixtures module #15843

wants to merge 3 commits into from

Conversation

scottjbeck
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
pawelgolda
pawelgolda reviewed Oct 6, 2017
View reviewed changes
test/parallel/test-https-localaddress-bind-error.js Outdated
const options = {
key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`),
cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`)
key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the proper change here would be:

const options = {
  key: fixtures.readKey('agent1-key.pem'),
  cert: fixtures.readKey('agent1-cert')
}

@mscdex mscdex added the https Issues or PRs related to the https subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
@jasnell
Copy link
Member

jasnell commented Oct 9, 2017

Thank you so much for the contribution and for participating in the code-and-learn! There are a couple of additional bits that need worked on for this PR but it's very close!

@gireeshpunathil
Copy link
Member

soft ping @scottjbeck

@BridgeAR
Copy link
Member

Ping @scottjbeck

@gireeshpunathil
Copy link
Member

CI pending (revisit post CI embargo)

@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10945/

@gireeshpunathil
Copy link
Member

@scottjbeck - basically the linter failed due to the fact that:

  ---
  message: '''fs'' is assigned a value but never used.'
  severity: error
  data:
    line: 28
    column: 7
    ruleId: no-unused-vars

Will you please simply remove that line?

@gireeshpunathil
Copy link
Member

new CI: https://ci.nodejs.org/job/node-test-pull-request/11020/

@joyeecheung
Copy link
Member

CI failures are unrelated.

@tniessen
Copy link
Member

Landed in 64aded3, thank you! 🎉

@tniessen tniessen closed this Oct 28, 2017
tniessen pushed a commit that referenced this pull request Oct 28, 2017
@scottjbeck @tniessen
test: use fixtures module
64aded3 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@scottjbeck @gibfahn
test: use fixtures module
fcc95a0 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@scottjbeck @gibfahn
test: use fixtures module
fb7068e 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@scottjbeck @gibfahn
test: use fixtures module
fe9cca2 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gibfahn gibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@scottjbeck @Qard
test: use fixtures module
da91c81 
PR-URL: nodejs/node#15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@scottjbeck @Qard
test: use fixtures module
51373db 
PR-URL: nodejs/node#15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@scottjbeck @MylesBorins
test: use fixtures module
124bc37 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@scottjbeck @MylesBorins
test: use fixtures module
a5e2511 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@scottjbeck @MylesBorins
test: use fixtures module
532c960 
PR-URL: #15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@scottjbeck @addaleax
test: use fixtures module
93f52a0 
PR-URL: nodejs/node#15843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelgolda pawelgolda pawelgolda left review comments

@jasnell jasnell jasnell left review comments

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.